Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 21 Sep 2022 12:50:56 +0800
From:   kernel test robot <lkp@intel.com>
To:     Ian Lin <ian.lin@infineon.com>, linux-wireless@vger.kernel.org
Cc:     kbuild-all@lists.01.org, brcm80211-dev-list@broadcom.com,
        brcm80211-dev-list@cypress.com, franky.lin@broadcom.com,
        hante.meuleman@broadcom.com, kvalo@kernel.org,
        Double.Lo@infineon.com, ian.lin@infineon.com
Subject: Re: [PATCH 1/3] brcmfmac: Support DPP feature
Message-ID: <202209211219.PmRhFKDc-lkp@intel.com>
References: <20220921015951.16178-2-ian.lin@infineon.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220921015951.16178-2-ian.lin@infineon.com>
Precedence: bulk

Hi Ian,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on wireless-next/main]
[also build test WARNING on wireless/main linus/master v6.0-rc6 next-20220920]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Ian-Lin/brcmfmac-Support-DPP-feature-series/20220921-101658
base:   https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git main
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20220921/202209211219.PmRhFKDc-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/a4592ec96782290389bab0b4ca9cd9bc0ae4672a
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Ian-Lin/brcmfmac-Support-DPP-feature-series/20220921-101658
        git checkout a4592ec96782290389bab0b4ca9cd9bc0ae4672a
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/net/wireless/broadcom/brcm80211/brcmfmac/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c: In function 'brcmf_p2p_tx_action_frame':
>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c:1587:13: warning: variable 'action_frame_len' set but not used [-Wunused-but-set-variable]
    1587 |         u16 action_frame_len;
         |             ^~~~~~~~~~~~~~~~


vim +/action_frame_len +1587 drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c

  1564	
  1565	
  1566	/**
  1567	 * brcmf_p2p_tx_action_frame() - send action frame over fil.
  1568	 *
  1569	 * @p2p: p2p info struct for vif.
  1570	 * @af_params: action frame data/info.
  1571	 * @vif: vif to send
  1572	 *
  1573	 * Send an action frame immediately without doing channel synchronization.
  1574	 *
  1575	 * This function waits for a completion event before returning.
  1576	 * The WLC_E_ACTION_FRAME_COMPLETE event will be received when the action
  1577	 * frame is transmitted.
  1578	 */
  1579	static s32 brcmf_p2p_tx_action_frame(struct brcmf_p2p_info *p2p,
  1580					     struct brcmf_fil_af_params_le *af_params,
  1581					     struct brcmf_cfg80211_vif *vif
  1582					     )
  1583	{
  1584		struct brcmf_pub *drvr = p2p->cfg->pub;
  1585		s32 err = 0;
  1586		struct brcmf_fil_action_frame_le *action_frame;
> 1587		u16 action_frame_len;
  1588	
  1589		action_frame = &af_params->action_frame;
  1590		action_frame_len = le16_to_cpu(action_frame->len);
  1591	
  1592		brcmf_dbg(TRACE, "Enter\n");
  1593	
  1594		reinit_completion(&p2p->send_af_done);
  1595		clear_bit(BRCMF_P2P_STATUS_ACTION_TX_COMPLETED, &p2p->status);
  1596		clear_bit(BRCMF_P2P_STATUS_ACTION_TX_NOACK, &p2p->status);
  1597	
  1598		err = brcmf_fil_bsscfg_data_set(vif->ifp, "actframe", af_params,
  1599						sizeof(*af_params));
  1600		if (err) {
  1601			bphy_err(drvr, " sending action frame has failed\n");
  1602			goto exit;
  1603		}
  1604	
  1605		p2p->af_sent_channel = le32_to_cpu(af_params->channel);
  1606		p2p->af_tx_sent_jiffies = jiffies;
  1607	
  1608		if (test_bit(BRCMF_P2P_STATUS_DISCOVER_LISTEN, &p2p->status) &&
  1609		    p2p->af_sent_channel ==
  1610		    ieee80211_frequency_to_channel(p2p->remain_on_channel.center_freq))
  1611			p2p->wait_for_offchan_complete = false;
  1612		else
  1613			p2p->wait_for_offchan_complete = true;
  1614	
  1615		brcmf_dbg(TRACE, "Waiting for %s tx completion event\n",
  1616			  (p2p->wait_for_offchan_complete) ?
  1617			   "off-channel" : "on-channel");
  1618	
  1619		wait_for_completion_timeout(&p2p->send_af_done, P2P_AF_MAX_WAIT_TIME);
  1620	
  1621		if (test_bit(BRCMF_P2P_STATUS_ACTION_TX_COMPLETED, &p2p->status)) {
  1622			brcmf_dbg(TRACE, "TX action frame operation is success\n");
  1623		} else {
  1624			err = -EIO;
  1625			brcmf_dbg(TRACE, "TX action frame operation has failed\n");
  1626		}
  1627		/* clear status bit for action tx */
  1628		clear_bit(BRCMF_P2P_STATUS_ACTION_TX_COMPLETED, &p2p->status);
  1629		clear_bit(BRCMF_P2P_STATUS_ACTION_TX_NOACK, &p2p->status);
  1630	
  1631	exit:
  1632		return err;
  1633	}
  1634	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp