Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 21 Sep 2022 13:34:17 +0300
From:   Ido Schimmel <idosch@nvidia.com>
To:     Gaosheng Cui <cuigaosheng1@huawei.com>
Cc:     petrm@nvidia.com, davem@davemloft.net, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com, nbd@nbd.name,
        lorenzo@kernel.org, ryder.lee@mediatek.com,
        shayne.chen@mediatek.com, sean.wang@mediatek.com, kvalo@kernel.org,
        matthias.bgg@gmail.com, amcohen@nvidia.com,
        stephen@networkplumber.org, netdev@vger.kernel.org,
        linux-wireless@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 1/5] mlxsw: reg: Remove unused inline function
 mlxsw_reg_sftr2_pack()
Message-ID: <YyroqT8a0InvBaaL@shredder>
References: <20220921090455.752011-1-cuigaosheng1@huawei.com>
 <20220921090455.752011-2-cuigaosheng1@huawei.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220921090455.752011-2-cuigaosheng1@huawei.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?05ttYsbqlAqZtgq1HfwdFbaezzVwZKQ4whfXskYHPcWFktuI14yQg+2Y8cYh?=
 =?us-ascii?Q?d9PZb30DfjEhJuSSQOfI+r3ToL6BGOnkfNtvy8SlP4M0M7CmD7MzLUX6LjLr?=
 =?us-ascii?Q?q0cjSH2PwEN6GUKrke3B0xHDv1dag71t7lZ8j6SGEqoUAZwcG0xHm4LKZ99Z?=
 =?us-ascii?Q?TfxeI1xtDG2HFItDuRFwPYDYsfk0ACxLBvR5zfVsCYB9l8XYsh9uMe2/Nvkl?=
 =?us-ascii?Q?VJsRdTjX8ouZbjxHuBbV2SZLhZa43C1o8rE+7tpUYxRu7+28wognvRW3j89S?=
 =?us-ascii?Q?Zqmqc0Cm4230yKWQYqvF0L0rw8viLErDQw8iKBz5IWi5jhrgj6Xl61U5AQ8E?=
 =?us-ascii?Q?h1mXjZBW4YMlZ6AZ3RIsbbZ28786gOSDMT1DQi7oKAbl0Pk1+tRzBkbrPdU4?=
 =?us-ascii?Q?5c+MXT2RCsTqIyMRe07kWR8/HKK/Ar5ZAJr4uHWGqL6Q1IywDRjAa1aTOUWj?=
 =?us-ascii?Q?WymJ9bqX2pQhUNeV3e9wYoo7CiHy9ffqTwaIGckX5u8eCXR7nV9Jow2qEv3W?=
 =?us-ascii?Q?qk7w8jx+m+7ndljLu5+h5GATgse9cWvJwxW+r9J56/Ud9sgr5QDvW5I5F4Ul?=
 =?us-ascii?Q?7YJeg2T3gfmOhjQFLrhjWlGNAr++pSXnoZKHYOg9IwWvb7HrdI1SNtQiHrRQ?=
 =?us-ascii?Q?zjRC9bYDz/jzEghRSZg/XX8b5nr/cH9pFztYviMn3FO49rO4uCOHAsBeYGGH?=
 =?us-ascii?Q?LkWWGO1VxSn/aJL9cTTHr10pakF2xAeY2oTk35hvFIQk4Rdh94ko6qweGbg7?=
 =?us-ascii?Q?LhZKl9ETHYWUjis9qobd+egkw/HjtND/IjxdURlCwQZIYRKztciytnqCw5JT?=
 =?us-ascii?Q?LwSFFlPCtLnHa2Bcr/o3v3hpCJYCc708HyaIYpAjvpIlPzHQ/Mxdkh3i0vO9?=
 =?us-ascii?Q?7LsnodalbgqeGaVN7fe0iRqD2RRD5RjcFzP/sHy8kf9LV00ntDluBsyR3IWK?=
 =?us-ascii?Q?9PHhUfCLQnsGIfxez2sudc88gWM7eAigcC8Etbv/R3Hny6SUv4SGKiLOMjgg?=
 =?us-ascii?Q?9Le/LrrBjikA8st+q3BcsKczlIbb7WqzKOA2DlhjWd0edpXM83kJR+CEr9Fi?=
 =?us-ascii?Q?QW13JwTZGqrU0lv2Lq/1w3tsePKiiFOiL6xnzUMI2+H1o56TdL1k1vVj3Vak?=
 =?us-ascii?Q?r8+8H5JAU1pRjvG/pAG/WNv2G4oOR+fXS9U94TlziCsXwKw/78CknH8Gjrg1?=
 =?us-ascii?Q?mKL/auh6faETSNcAT5NclioGN80JXodPvNpJussEr+RaBOhIRiOACSBXi3nm?=
 =?us-ascii?Q?WcVinqoMHHyH7+GSB15MK7ruNH+y/su6pt5ZHvd3/M2V1o+NnBXCyxPwGRSL?=
 =?us-ascii?Q?dZ2tdHWfUwdJ3LsfuAmJNSciGNy/X99Rc35nuDZOqEX8ae4RKo1nSMHUSYpP?=
 =?us-ascii?Q?/cOi7q1h6k3CVlx0ckodvf1ORjZjQ6rIjlALOC0ekQbCthylLWB74sHmtSi4?=
 =?us-ascii?Q?Mfmh/389Z8B23lN9BxjtCVTaDBAXfDKtOrDHMspLWVudvKuWedW+nLO7d0BX?=
 =?us-ascii?Q?UakIOUWtEhs1Zg4Ax1waqZcoVpnlqWelk5uMYpixWnJnwa8I5P8DNGPBPgBw?=
 =?us-ascii?Q?SXkXsrm0bAn9+/LFSOMv56UrcT5eOSA4+jtZ3K39?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0559a101-4b5b-4d59-aba2-08da9bbcd97d
X-MS-Exchange-CrossTenant-AuthSource: CY5PR12MB6179.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2022 10:34:23.2645
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1p7ZpbEOIiWcrl0hWxKlpEs4zZCdv6zegIiC32VWj+Nfr/O74VGMGWfrE/+E5XMyJAGZSr5EXl3QfhbWHxQ4jA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB5612
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

On Wed, Sep 21, 2022 at 05:04:51PM +0800, Gaosheng Cui wrote:
> All uses of mlxsw_reg_sftr2_pack() have
> been removed since commit 77b7f83d5c25 ("mlxsw: Enable unified
> bridge model"), so remove it.

Please rather remove the entire register in v2 [1].

Subject prefix should be "PATCH net-next":
https://docs.kernel.org/process/maintainer-netdev.html#how-do-i-indicate-which-tree-net-vs-net-next-my-patch-should-be-in

Thanks

[1]
diff --git a/drivers/net/ethernet/mellanox/mlxsw/reg.h b/drivers/net/ethernet/mellanox/mlxsw/reg.h
index b293a154e49f..1cc117c8f230 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/reg.h
+++ b/drivers/net/ethernet/mellanox/mlxsw/reg.h
@@ -2251,76 +2251,6 @@ static inline void mlxsw_reg_smpe_pack(char *payload, u16 local_port,
 	mlxsw_reg_smpe_evid_set(payload, evid);
 }
 
-/* SFTR-V2 - Switch Flooding Table Version 2 Register
- * --------------------------------------------------
- * The switch flooding table is used for flooding packet replication. The table
- * defines a bit mask of ports for packet replication.
- */
-#define MLXSW_REG_SFTR2_ID 0x202F
-#define MLXSW_REG_SFTR2_LEN 0x120
-
-MLXSW_REG_DEFINE(sftr2, MLXSW_REG_SFTR2_ID, MLXSW_REG_SFTR2_LEN);
-
-/* reg_sftr2_swid
- * Switch partition ID with which to associate the port.
- * Access: Index
- */
-MLXSW_ITEM32(reg, sftr2, swid, 0x00, 24, 8);
-
-/* reg_sftr2_flood_table
- * Flooding table index to associate with the specific type on the specific
- * switch partition.
- * Access: Index
- */
-MLXSW_ITEM32(reg, sftr2, flood_table, 0x00, 16, 6);
-
-/* reg_sftr2_index
- * Index. Used as an index into the Flooding Table in case the table is
- * configured to use VID / FID or FID Offset.
- * Access: Index
- */
-MLXSW_ITEM32(reg, sftr2, index, 0x00, 0, 16);
-
-/* reg_sftr2_table_type
- * See mlxsw_flood_table_type
- * Access: RW
- */
-MLXSW_ITEM32(reg, sftr2, table_type, 0x04, 16, 3);
-
-/* reg_sftr2_range
- * Range of entries to update
- * Access: Index
- */
-MLXSW_ITEM32(reg, sftr2, range, 0x04, 0, 16);
-
-/* reg_sftr2_port
- * Local port membership (1 bit per port).
- * Access: RW
- */
-MLXSW_ITEM_BIT_ARRAY(reg, sftr2, port, 0x20, 0x80, 1);
-
-/* reg_sftr2_port_mask
- * Local port mask (1 bit per port).
- * Access: WO
- */
-MLXSW_ITEM_BIT_ARRAY(reg, sftr2, port_mask, 0xA0, 0x80, 1);
-
-static inline void mlxsw_reg_sftr2_pack(char *payload,
-					unsigned int flood_table,
-					unsigned int index,
-					enum mlxsw_flood_table_type table_type,
-					unsigned int range, u16 port, bool set)
-{
-	MLXSW_REG_ZERO(sftr2, payload);
-	mlxsw_reg_sftr2_swid_set(payload, 0);
-	mlxsw_reg_sftr2_flood_table_set(payload, flood_table);
-	mlxsw_reg_sftr2_index_set(payload, index);
-	mlxsw_reg_sftr2_table_type_set(payload, table_type);
-	mlxsw_reg_sftr2_range_set(payload, range);
-	mlxsw_reg_sftr2_port_set(payload, port, set);
-	mlxsw_reg_sftr2_port_mask_set(payload, port, 1);
-}
-
 /* SMID-V2 - Switch Multicast ID Version 2 Register
  * ------------------------------------------------
  * The MID record maps from a MID (Multicast ID), which is a unique identifier
@@ -12876,7 +12806,6 @@ static const struct mlxsw_reg_info *mlxsw_reg_infos[] = {
 	MLXSW_REG(spvc),
 	MLXSW_REG(spevet),
 	MLXSW_REG(smpe),
-	MLXSW_REG(sftr2),
 	MLXSW_REG(smid2),
 	MLXSW_REG(cwtp),
 	MLXSW_REG(cwtpm),