Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp372590rwb; Thu, 22 Sep 2022 00:18:05 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7vXq5I3vb2mGxT1BN56YLLeNX4WQeFvIf7fhbFARzyBZO/HahANnQBTGzMHGddHrfAqJ+5 X-Received: by 2002:a05:6402:34cb:b0:451:61c9:a316 with SMTP id w11-20020a05640234cb00b0045161c9a316mr1905440edc.268.1663831085467; Thu, 22 Sep 2022 00:18:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663831085; cv=none; d=google.com; s=arc-20160816; b=V8U7s6p1cAc50o9esVq7yrRc7i+9RH3l6b5DeBG0Bm2pF5XbLRypPaOWejVcJ52J96 LFOq5DLRyAY4eNL26vXgi/Sw2uVu+qN8PL/03kbt7Nyth6ccmVr0dFqE79pV6c5E4BVD mzWiT97x4VaBUDGei54Q4WKsPMHFbnRybCIE2uVGeEN0LonYXW6Zibn7bYI0GZW6uo3i Bad9UbMLHmpC9kHtaSnL4ZKRSVcp5TidfiubOPlP4UAQsmp+Za+ZO+TsTT9urXUMhHzj KWWqB+hRUpiwwkGLO/5pXonAe5w8VB00LhVNjVYnyv87bJcYjP4nTM6/JNsIWEkOLUkV 6ljA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=Nmfx/tPsymFmUApmXgYykuDUQuVxtDt0bLTiz3BDyLY=; b=ij2fJJXfFpmIOCLlASN/6R0HbPuftB/obaebx0R5c07aAzcemYQoCWfIXgg7CIKP/D VqDQX3bAjQy91LoXsP16maxJnwrosdZNnWm4XWLNaPSkIPrjqs9UStkP6FxXzDsLXRmb qtmD/TNWKLeagW/YbZS1oFV1zbsdaJWoKKZ4eaos85V8mQArHuVAE1dTnsRK1IqL/mu6 WJNy9Em4DgzjW3w4ysCGslQmSwj1cqIdQ+tdvQQdI9Z2eXdZ5CSQ3fjvHHNKgRflppjt B2wQKCqLdzrNKaeRcP7CVVF7ZGl3deVzn/lKKXKVaIzLHh6bvEZReVgQ6smRAJ9FvMT2 hiiA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=atBbsP5y; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c17-20020aa7df11000000b0044e6cd50e66si4229684edy.282.2022.09.22.00.17.48; Thu, 22 Sep 2022 00:18:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=atBbsP5y; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230341AbiIVHQ6 (ORCPT + 63 others); Thu, 22 Sep 2022 03:16:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230353AbiIVHQg (ORCPT ); Thu, 22 Sep 2022 03:16:36 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64B0DB4A9 for ; Thu, 22 Sep 2022 00:16:04 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9789C6341A for ; Thu, 22 Sep 2022 07:16:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EBD42C433C1; Thu, 22 Sep 2022 07:16:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663830963; bh=Ug3vdNZrUkehAQu0PPgU5X+QRZMeNzLGuhSE+RMFoqI=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=atBbsP5yZSiGDed0UEwbyYHSK+qTEfxtHlp3+BtfvI1XCMeRsPuo2wVdzQJr5wvIJ 6lemTDN78N2ofHRyJgJ+aw+Y+kGcZLu3BOlOgGypDBBt7CM8xQxe6lukG0WPEvymXu M4wCMm1uD3nPvb53MSBT6wLHUoxOAQXzd2HEgGbi4hfzujmXvbtiBY7VUAkxrMlZwp Po5W56bqHp3pT+3tuJ7hxsJKM+AChWjDfrMcau7VjEDyWzVBPvP+DqJVC8nQYfYoHq pkR1shxy0JFbE5k7QkfYHoSXSl19FRW0GuC5k3fn4CpqaKRepbxAGBvDkXRt8s/6Po MduKYyHZvB5FA== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wifi: ath11k: change complete() to complete_all() for scan.completed From: Kalle Valo In-Reply-To: <20220919024413.25083-1-quic_wgong@quicinc.com> References: <20220919024413.25083-1-quic_wgong@quicinc.com> To: Wen Gong Cc: , , User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <166383095879.28267.7782431891959207921.kvalo@kernel.org> Date: Thu, 22 Sep 2022 07:16:01 +0000 (UTC) X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Wen Gong wrote: > Currently commit 1f682dc9fb37 ("ath11k: reduce the wait time of 11d scan > and hw scan while add interface") introduced a wait_for_completion_timeout > operation for ar->scan.completed, another one is existed in ath11k_scan_stop(), > then ath11k has two places to wait for the ar->scan.completed and they > run in different thread, thus it is possible to happend that the two > thread both enter wait status. To handle this scenario, ath11k should > change the complete() to complete_all() for the ar->scan.completed. This > also work well when it is only one thread wait for ar->scan.completed. > > Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3 > > Signed-off-by: Wen Gong > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 7855a6ed5cf7 wifi: ath11k: change complete() to complete_all() for scan.completed -- https://patchwork.kernel.org/project/linux-wireless/patch/20220919024413.25083-1-quic_wgong@quicinc.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches