Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp447165rwb; Thu, 22 Sep 2022 01:43:57 -0700 (PDT) X-Google-Smtp-Source: AMsMyM71H9DTV+pu8vtjCEoQNwRz6kfC6pbINUTA3YcaiUxKV3IvZkUQqZxPxvfqjsbHzwo9E4cZ X-Received: by 2002:a63:5d53:0:b0:43b:2e65:6fa6 with SMTP id o19-20020a635d53000000b0043b2e656fa6mr2115614pgm.115.1663836237028; Thu, 22 Sep 2022 01:43:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663836237; cv=none; d=google.com; s=arc-20160816; b=s93ZgxUsMEIQqR6yXB27tqDr52LAtp2xr7DEj02M5mK9uU5h7XCJsQuxc6mv8gb9Av xnf4HB8wc7832rh5O3Rmup32Q5XW6E1c/OEzKSvZ2peoR4HOSr2tYNrUTSKGYN+4QP1B qLRu4Xxq6rrNM656xHQK7uhgxpKBla3mCSgkdTC0JLEVqUTeth4Ok7n0JTBIvY991Wh3 rWpvin+qZ2ar8MTrQavLT8WnIjBoCoyah8FhzbeObpkcv0+B4fQWuizpnYxtwECXBXmi 8pKp/XmRJr6oprx1vrO5n/gLol8G1F0xJ1oPyGjsf3VjMvg8jqsuRb1QQS7obQZc7G6W 9iKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=fQD0O8g5hmuK1aY7SLmnL73aOmZ5cict+s/hma0utvk=; b=TT7t8yRbl+y2GuY6ofg/XmHHe5Ep6SPV+7/Vj6XQsXeqlgE2f92xp2URNPZUaKYruE 6K8v6lIysi9BRU/I7C3pMlyHQqPyETDQJv7waiJmUsJ1ZIRTzMs3cdNC5n9FtBfcs/Hh eHKswxXrszqE7D4sPdoBZBCTZWiUR3H16QB3EKftsetMzntAwooUgph2Keii1c9TchAn Zh1LedSC81PXlpy6aK4fRDvo1Xin1sUfdqKUdwG+XI33FnLoSP9LXNiPjg0R0CZ8XJ4q eG95JJEfErkGcel84YyYde9irkHZbWWVylfk7CvgqTwv5qvxCO1LpyNSZO4sjQoULvwS xsVQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="Myb5Zos/"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p1-20020a634f41000000b0043945685065si5347937pgl.36.2022.09.22.01.43.48; Thu, 22 Sep 2022 01:43:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="Myb5Zos/"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229609AbiIVIfc (ORCPT + 63 others); Thu, 22 Sep 2022 04:35:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229944AbiIVIf3 (ORCPT ); Thu, 22 Sep 2022 04:35:29 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49B9A4E853 for ; Thu, 22 Sep 2022 01:35:28 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 62AA6CE1FCE for ; Thu, 22 Sep 2022 08:35:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 98A18C433D7; Thu, 22 Sep 2022 08:35:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663835722; bh=LzYixJB53o4lrYmnQpu6l9b3KeR5dskhXKC15wJwOW8=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=Myb5Zos/+R8NGrvzoedBHSVKxD+/DYQikKtB9TnWTKCPS61BNW7zSR0Y8kyJWSvkB vVZ7JZqwgwbAywZ7xgMQulnZK6Yd6xjC7DoZ4Dvel4bLoXES8K6d0HACdumBn4gKye dbVbQ6uWwwLVrqiNTvFdX5/D2JEMfoSD4mUpckVXD/5hCFiIB9anVgYfMAk3Kp+uyd ZxRStr6X0N8VBu1FJCGVgh0wHa5W+x/K7cz+zRpUbVXMcsumtZLCbIMmX7dHd9Bm5E oQ1sDPeujft/clAmVYPIttfrOS5Af5B3l1YcLdlxOazU958puRgSY4UrVNP9UpGXj2 XMMTxNP+op/rA== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] ath11k: fix number of VHT beamformee spatial streams From: Kalle Valo In-Reply-To: <20220616173947.21901-1-jesus.manzano@galgus.net> References: <20220616173947.21901-1-jesus.manzano@galgus.net> To: Jesus Fernandez Manzano Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, jesus.manzano@galgus.net User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <166383571956.27663.10307320275505026019.kvalo@kernel.org> Date: Thu, 22 Sep 2022 08:35:21 +0000 (UTC) X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Jesus Fernandez Manzano wrote: > The number of spatial streams used when acting as a beamformee in VHT > mode are reported by the firmware as 7 (8 sts - 1) both in IPQ6018 and > IPQ8074 which respectively have 2 and 4 sts each. So the firmware should > report 1 (2 - 1) and 3 (4 - 1). > > Fix this by checking that the number of VHT beamformee sts reported by > the firmware is not greater than the number of receiving antennas - 1. > The fix is based on the same approach used in this same function for > sanitizing the number of sounding dimensions reported by the firmware. > > Without this change, acting as a beamformee in VHT mode is not working > properly. > > Tested-on: IPQ6018 hw1.0 AHB WLAN.HK.2.5.0.1-01208-QCAHKSWPL_SILICONZ-1 > Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.5.0.1-01208-QCAHKSWPL_SILICONZ-1 > > Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices") > Signed-off-by: Jesus Fernandez Manzano > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 55b5ee3357d7 wifi: ath11k: fix number of VHT beamformee spatial streams -- https://patchwork.kernel.org/project/linux-wireless/patch/20220616173947.21901-1-jesus.manzano@galgus.net/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches