Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp806634rwb; Thu, 22 Sep 2022 06:41:53 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7p3ETgdCd4sIZWkMsmkfKohCKh38mfZpR1aF4gAk/0SrGoKe+4aPKjXJXeAQ5xmloPirsK X-Received: by 2002:a17:90a:f8c6:b0:203:21f3:f22e with SMTP id l6-20020a17090af8c600b0020321f3f22emr3767377pjd.36.1663854113327; Thu, 22 Sep 2022 06:41:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663854113; cv=none; d=google.com; s=arc-20160816; b=z0+jH08mz88uY5Zlb+PtFOXWq5UYwKzKIqHTOFc1j0tTk5clo1rQgRBoYw08ciao91 TxR99lQhV0Ls7us8ooxjth2XY5jO3BDMxCI3aD0C0C90aW2o6CmtAZ3D74vZuOKDowIF ZzZrGcfZiIDErOCzZS/tjAHTwzgOz1c9JjOYlNrdPjIXBpg+rrahtkk5SUZttH+StLlc R8txZfpVqita8RGF9Fuq2JkdnLw4sw4ZzUlGyJhB9xaAb3fbrcKO/AO63TGBN9K6c39Z As8Dqu0TcVhsTz+loERdY5hIMF/m2KveN2nHbgtFLA7IG8yJEEMmw+zDS84Ud1ivhQsx YOVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:reply-to:message-id:subject:cc:to:from:date :dkim-signature:dkim-signature; bh=IwL9ZLjfbaspCU82c8med1UAPhmCPx1OWhj8R1+9qNM=; b=A9wOb7BzGJGrHB5tf59pqUoV+GKKV/UMwhgVPfNHRjmzY1/riYAw1D53PrKm1XZbV+ SAfrikd6lOb5na9Tnt6Spc4/Jehssli+gzDoaL/36P+KlHcV30kF3TTXAfxJET2JT2MB K7G0WexFiiide66rCXngqs/T1rKIJx7q3narbXJHSlvxdb/smToxoSl0zpVwZQrORoRT 0bjegVXE5if5rEyl2IlrH447nJ1KeE7d248goFmCuW8A2kff6eUri7YM65Lts4qRq/Me Sb3YOfzW7/BpRcQKrSwVpPAanLRNv5jclFXhwPtlUrwAQaq3EnXenFm9PeffT8mnsq51 DteQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=XihVZkR0; dkim=neutral (no key) header.i=@suse.cz; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y11-20020a17090aca8b00b00202bb6e0923si5754148pjt.155.2022.09.22.06.41.42; Thu, 22 Sep 2022 06:41:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=XihVZkR0; dkim=neutral (no key) header.i=@suse.cz; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230186AbiIVNgp (ORCPT + 63 others); Thu, 22 Sep 2022 09:36:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231551AbiIVNgV (ORCPT ); Thu, 22 Sep 2022 09:36:21 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B2173E62CC; Thu, 22 Sep 2022 06:35:49 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 312D81F8F8; Thu, 22 Sep 2022 13:35:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1663853747; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IwL9ZLjfbaspCU82c8med1UAPhmCPx1OWhj8R1+9qNM=; b=XihVZkR0NFlKaTEY2REooJ4nnysnnfLcvjy51KzgHbSW+oLtMuf9IonwLm/KkASRNsstRo s4Dx+Q4cpaICoaXsH0DUfapvCIci0Ubcv9A9s0vR8XX8+NUFKAnyoOuIT9zDwNjs4dr4X/ qezh4tAzHSN1OltdzTUMbRixdeL8EVg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1663853747; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IwL9ZLjfbaspCU82c8med1UAPhmCPx1OWhj8R1+9qNM=; b=D4SrbPeIUjJXDbzN3l/v7S9Ic5eD5VW9j9nh63nD86Qj+hCZa1n0PAF8TSLqyf+7TdxxOs g6cysoCnwD04I3Cw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5C8F513AA5; Thu, 22 Sep 2022 13:35:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id RvYRFbJkLGM6egAAMHmgww (envelope-from ); Thu, 22 Sep 2022 13:35:46 +0000 Date: Thu, 22 Sep 2022 15:30:14 +0200 From: David Sterba To: Kees Cook Cc: Vlastimil Babka , linux-btrfs@vger.kernel.org, Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Greg Kroah-Hartman , Nick Desaulniers , Alex Elder , Josef Bacik , David Sterba , Sumit Semwal , Christian =?iso-8859-1?Q?K=F6nig?= , Jesse Brandeburg , Daniel Micay , Yonghong Song , Marco Elver , Miguel Ojeda , Jacob Shin , linux-kernel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-fsdevel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, dev@openvswitch.org, x86@kernel.org, linux-wireless@vger.kernel.org, llvm@lists.linux.dev, linux-hardening@vger.kernel.org Subject: Re: [PATCH 04/12] btrfs: send: Proactively round up to kmalloc bucket size Message-ID: <20220922133014.GI32411@suse.cz> Reply-To: dsterba@suse.cz References: <20220922031013.2150682-1-keescook@chromium.org> <20220922031013.2150682-5-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220922031013.2150682-5-keescook@chromium.org> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Wed, Sep 21, 2022 at 08:10:05PM -0700, Kees Cook wrote: > Instead of discovering the kmalloc bucket size _after_ allocation, round > up proactively so the allocation is explicitly made for the full size, > allowing the compiler to correctly reason about the resulting size of > the buffer through the existing __alloc_size() hint. > > Cc: linux-btrfs@vger.kernel.org > Signed-off-by: Kees Cook Acked-by: David Sterba