Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kalle Valo <kvalo@kernel.org>
To:     Ping-Ke Shih <pkshih@realtek.com>
Cc:     <Larry.Finger@lwfinger.net>, <stable@vger.kernel.org>,
        <phhuang@realtek.com>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v6.0-rc] wifi: rtw89: free unused skb to prevent memory leak
References: <20220926021513.5029-1-pkshih@realtek.com>
Date:   Mon, 26 Sep 2022 08:26:44 +0300
In-Reply-To: <20220926021513.5029-1-pkshih@realtek.com> (Ping-Ke Shih's
        message of "Mon, 26 Sep 2022 10:15:13 +0800")
Message-ID: <87illa7lkb.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Ping-Ke Shih <pkshih@realtek.com> writes:

> From: Po-Hao Huang <phhuang@realtek.com>
>
> This avoid potential memory leak under power saving mode.
>
> Fixes: fc5f311fce74 ("rtw89: don't flush hci queues and send h2c if power is off")
> Cc: stable@vger.kernel.org
> Cc: Larry Finger <Larry.Finger@lwfinger.net>
> Signed-off-by: Po-Hao Huang <phhuang@realtek.com>
> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
> Signed-off-by: Kalle Valo <kvalo@kernel.org>
> Link: https://lore.kernel.org/r/20220916033811.13862-6-pkshih@realtek.com
> ---
> Hi Kalle,
>
> We want this patch go to v6.0-rc, because it can fix memleak caused by another
> patch. For users, this driver eats memory and could lead out-of-memory
> finally.
>
> This patch has been merged into wireless-next, but I forget to add "Fixes"
> tag and Cc stable, so I add them to commit messages. If this works, I will
> prepare another patch for v5.19.

-rc7 is already released, so we are quite late in the cycle, and I'm not
planning to submit another pull request for v6.0 unless something really
major happens. So I think it's better that you wait for the -next commit
to reach Linus' tree (should happen in next two weeks or so) and then
submit a patch to stable releases.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches