Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Authenticated-By: 
From:   Ping-Ke Shih <pkshih@realtek.com>
To:     Kalle Valo <kvalo@kernel.org>
CC:     "Larry.Finger@lwfinger.net" <Larry.Finger@lwfinger.net>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>,
        Bernie Huang <phhuang@realtek.com>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: [PATCH v6.0-rc] wifi: rtw89: free unused skb to prevent memory leak
Thread-Topic: [PATCH v6.0-rc] wifi: rtw89: free unused skb to prevent memory
 leak
Thread-Index: AQHY0U4EOim9sNze6EW8zSbMJWZSDq3xLqbDgAAEtTA=
Date:   Mon, 26 Sep 2022 05:45:42 +0000
Message-ID: <a72c494ad56c44d0a2a4219d0a671ab5@realtek.com>
References: <20220926021513.5029-1-pkshih@realtek.com>
 <87illa7lkb.fsf@kernel.org>
In-Reply-To: <87illa7lkb.fsf@kernel.org>
Accept-Language: en-US, zh-TW
Content-Language: zh-TW
x-kse-attachmentfiltering-interceptor-info: no applicable attachment filtering
 rules found
x-kse-antivirus-interceptor-info: scan successful
x-kse-antivirus-info: =?us-ascii?Q?Clean,_bases:_2022/9/26_=3F=3F_03:21:00?=
x-kse-bulkmessagesfiltering-scan-result: protection disabled
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-KSE-ServerInfo: RTEXH36504.realtek.com.tw, 9
X-KSE-AntiSpam-Interceptor-Info: fallback
X-KSE-Antivirus-Interceptor-Info: fallback
X-KSE-AntiSpam-Interceptor-Info: fallback
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE,
        SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org


> -----Original Message-----
> From: Kalle Valo <kvalo@kernel.org>
> Sent: Monday, September 26, 2022 1:27 PM
> To: Ping-Ke Shih <pkshih@realtek.com>
> Cc: Larry.Finger@lwfinger.net; stable@vger.kernel.org; Bernie Huang <phhuang@realtek.com>;
> linux-wireless@vger.kernel.org
> Subject: Re: [PATCH v6.0-rc] wifi: rtw89: free unused skb to prevent memory leak
> 
> Ping-Ke Shih <pkshih@realtek.com> writes:
> 
> > From: Po-Hao Huang <phhuang@realtek.com>
> >
> > This avoid potential memory leak under power saving mode.
> >
> > Fixes: fc5f311fce74 ("rtw89: don't flush hci queues and send h2c if power is off")
> > Cc: stable@vger.kernel.org
> > Cc: Larry Finger <Larry.Finger@lwfinger.net>
> > Signed-off-by: Po-Hao Huang <phhuang@realtek.com>
> > Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
> > Signed-off-by: Kalle Valo <kvalo@kernel.org>
> > Link: https://lore.kernel.org/r/20220916033811.13862-6-pkshih@realtek.com
> > ---
> > Hi Kalle,
> >
> > We want this patch go to v6.0-rc, because it can fix memleak caused by another
> > patch. For users, this driver eats memory and could lead out-of-memory
> > finally.
> >
> > This patch has been merged into wireless-next, but I forget to add "Fixes"
> > tag and Cc stable, so I add them to commit messages. If this works, I will
> > prepare another patch for v5.19.
> 
> -rc7 is already released, so we are quite late in the cycle, and I'm not
> planning to submit another pull request for v6.0 unless something really
> major happens. So I think it's better that you wait for the -next commit
> to reach Linus' tree (should happen in next two weeks or so) and then
> submit a patch to stable releases.
> 

Got it. I will do it weeks later. Thanks.

Ping-Ke