Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kalle Valo <kvalo@kernel.org>
To:     Jeff Johnson <quic_jjohnson@quicinc.com>
Cc:     "Lin Ian \(CSSITB CSS ICW SW WFS \/ EE\)" <ian.lin@infineon.com>,
        <linux-wireless@vger.kernel.org>,
        <brcm80211-dev-list@broadcom.com>,
        <brcm80211-dev-list@cypress.com>, <franky.lin@broadcom.com>,
        <hante.meuleman@broadcom.com>, <Double.Lo@infineon.com>
Subject: Re: [PATCH 4/5] brcmfmac: Update SSID of hidden AP while informing its bss to cfg80211 layer
References: <20220914033620.12742-1-ian.lin@infineon.com>
        <20220914033620.12742-5-ian.lin@infineon.com>
        <87tu506mre.fsf@kernel.org>
        <d390462d-1cd2-fc3f-5b0c-bdcd332ed0bc@infineon.com>
        <ff7e72ae-0431-b568-32fc-7b1cbf250e20@quicinc.com>
Date:   Mon, 26 Sep 2022 10:54:33 +0300
In-Reply-To: <ff7e72ae-0431-b568-32fc-7b1cbf250e20@quicinc.com> (Jeff
        Johnson's message of "Fri, 23 Sep 2022 08:29:34 -0700")
Message-ID: <87czbi4ll2.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Jeff Johnson <quic_jjohnson@quicinc.com> writes:

>>>> @@ -3032,6 +3033,12 @@ static s32 brcmf_inform_single_bss(struct
>>>> brcmf_cfg80211_info *cfg,
>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 notify_ielen =3D le32_to_cpu(bi->=
ie_length);
>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 bss_data.signal =3D (s16)le16_to_=
cpu(bi->RSSI) * 100;
>>>>
>>>> +=C2=A0=C2=A0=C2=A0=C2=A0 ssid =3D brcmf_parse_tlvs(notify_ie, notify_=
ielen, WLAN_EID_SSID);
>>>> +=C2=A0=C2=A0=C2=A0=C2=A0 if (ssid && ssid->data[0] =3D=3D '\0' && ssi=
d->len =3D=3D bi->SSID_len) {
>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0 /* Update SSID for hidden AP */
>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0 memcpy((u8 *)ssid->data, bi->SSID, bi->SSID_len);
>>>> +=C2=A0=C2=A0=C2=A0=C2=A0 }
>>> memcpy() takes a void pointer so the cast is not needed.
>>
>> There should be a type casting since 'ssid' is a const pointer.
>> As you saw there will be build warning in PATCH v2 (sorry I didn't
>> notice that locally)
>> I will send PATCH v3 to restore type casting, is that ok?
>>
>
> writing through a const pointer seems broken.

Yeah, this is exactly why I don't like casting. I see so often casts
removing the const and that can lead to another problems.

--=20
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc=
hes