Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kalle Valo <kvalo@kernel.org>
To:     Ruan Jinjie <ruanjinjie@huawei.com>
Cc:     Franky Lin <franky.lin@broadcom.com>, <aspriel@gmail.com>,
        <hante.meuleman@broadcom.com>, <davem@davemloft.net>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
        <marcan@marcan.st>, <linus.walleij@linaro.org>,
        <rmk+kernel@armlinux.org.uk>, <soontak.lee@cypress.com>,
        <linux-wireless@vger.kernel.org>,
        <SHA-cyfmac-dev-list@infineon.com>,
        <brcm80211-dev-list.pdl@broadcom.com>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] wifi: brcmfmac: pcie: add missing pci_disable_device() in brcmf_pcie_get_resource()
References: <20220923093806.3108119-1-ruanjinjie@huawei.com>
        <CA+8PC_eCwv321DxoCMOrWNLw7NWkT9F0sD-=8GzygEXPJHFWWA@mail.gmail.com>
        <b5e39818-2961-ba3d-8552-f618c19f8fe6@huawei.com>
Date:   Mon, 26 Sep 2022 10:58:45 +0300
In-Reply-To: <b5e39818-2961-ba3d-8552-f618c19f8fe6@huawei.com> (Ruan Jinjie's
        message of "Sat, 24 Sep 2022 09:00:12 +0800")
Message-ID: <878rm64le2.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Ruan Jinjie <ruanjinjie@huawei.com> writes:

> On 2022/9/24 0:50, Franky Lin wrote:
>> On Fri, Sep 23, 2022 at 2:42 AM ruanjinjie <ruanjinjie@huawei.com> wrote:
>>>
>>> Add missing pci_disable_device() if brcmf_pcie_get_resource() fails.
>> 
>> Did you encounter any issue because of the absensent
>> pci_disable_device? A bit more context will be very helpful.
>> 
>
> We use static analysis via coccinelle to find the above issue. The
> command we use is below:
>
> spatch -I include -timeout 60 -very_quiet -sp_file
> pci_disable_device_missing.cocci
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c

Please include this information to the commit log, it helps to
understand the background of the fix.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches