Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp559272rwb; Mon, 26 Sep 2022 02:52:21 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7JvnclnhYkoWj6JNf8TxDGxT0xSWVAldCDWExMVNp3R+K8DjRZZgb6YSmdEyzdlRYc0J7Z X-Received: by 2002:a17:902:e54b:b0:178:75b9:f1e9 with SMTP id n11-20020a170902e54b00b0017875b9f1e9mr21386435plf.104.1664185940632; Mon, 26 Sep 2022 02:52:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664185940; cv=none; d=google.com; s=arc-20160816; b=UU0nbBzuCKxFl/4SL//CjTwFwk64XW+Fup5GWSbw3NVsrHrYspHnDHQNYM0VCV/f7g qv97rqURqDagGkJVmhMXRVCbDCA4DtDNVkPhKpfdqFdRM50q8Xxv7+IKiOapln/PUICo OALFUb8Y3UQUSIUiBF9ZCgRYOLyXvRjn2sWmvBqNxOHBmFW+7qEMSYpsboW42gnsqYr5 4AClOTu+AiRj1v1PPl1fzVgKDqiBRQAf0Qaiv8vCxgLucU2DuBBS0kJldIJ7fzfTiZ0V qefEynBbRP/xQYd5Z1xljkg2PfTLFcx8+8i1qxVDjFn4LSqGAuFlV2ARq0HGS3EK8u8C g9ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=EqgyaZalaEEQcVtU9hVxyTC/GKwnHOEVTTPmrdeqpwo=; b=tDEHxt+HhuyB3MB6psaeylmNRVf4EXJDCU8D6TevkXII9KeVXEK0rl3DDFwehFynjU 1oKM2HLSEyLP6c1bddqg9taibiNM+r83ErULjUHS9D0QqrvjvHCD1dC6zpZmJWGeK9nB 49kwPP0yYU6D6XMikDUd+icvWhoMV7JwOk6zTCBUdgDvgv7SEnthPOxfISjtmf9aB71H zFiBBtk/Ka3P4VMidWA6dwAwiJH4VT7tkmsZjhukC8j+cyv+b0ViRWTjIM13NkqiBhHE iVP1IZlZ+JNCjI9c7c610JunLNMEX5P68mmIdx4rvSk3M+vS+ImoLTXOxhOFlAkyk5j1 Tn0g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=omilYMEg; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v7-20020a632f07000000b00435731625aasi17910269pgv.67.2022.09.26.02.52.11; Mon, 26 Sep 2022 02:52:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=omilYMEg; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234026AbiIZJrH (ORCPT + 62 others); Mon, 26 Sep 2022 05:47:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234019AbiIZJqc (ORCPT ); Mon, 26 Sep 2022 05:46:32 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BBC4155A3 for ; Mon, 26 Sep 2022 02:45:58 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 335B7B80780 for ; Mon, 26 Sep 2022 09:40:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 27397C433C1; Mon, 26 Sep 2022 09:40:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664185248; bh=KZExA4qLutmcXLykvMCHov9T9r+TzGGb9WvyV10CAX0=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=omilYMEgoE9VFMrzNoPz/7jyv0RzCth5hvOXT9uDsdTbX6L1RXYsjVdsrf+OLARB3 XCwP1Hfg2SHobK0w+QJzeUSF35HLrTxpng8DJT9CmuZzmP0HU46Jir/+DpC8sjHPeE PXnWvcGizqLlLLK60jo2qPgCaDRiSs21QcrR8lS597To+IZsMvqff7p8nmolYp6HnJ dYyEVZhHXIssVx8E2A+G2xiBz5sV9tDWeZQL9oO7HXQYQ3OJnLTXKfRc85AYzK/bn9 CFLW6+89RFVbr7HidsRselHKmeDSpZq4qtzUeLR1bya8uP5cU3ytUmE5RpVAtqFX19 mKvrfX9ZHulbA== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wifi: ath11k: Remove redundant ath11k_mac_drain_tx From: Kalle Valo In-Reply-To: <20220919020259.1746-1-quic_bqiang@quicinc.com> References: <20220919020259.1746-1-quic_bqiang@quicinc.com> To: Baochen Qiang Cc: , User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <166418524644.13691.9971262730096379862.kvalo@kernel.org> Date: Mon, 26 Sep 2022 09:40:47 +0000 (UTC) X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Baochen Qiang wrote: > ath11k_mac_drain_tx is already called in ath11k_mac_wait_tx_complete, no need to call it again. So remove it. > > This is found in code review. > > Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3 > > Signed-off-by: Baochen Qiang > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. d50ebec14535 wifi: ath11k: Remove redundant ath11k_mac_drain_tx -- https://patchwork.kernel.org/project/linux-wireless/patch/20220919020259.1746-1-quic_bqiang@quicinc.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches