Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3cd8fab9b36f5a263dfa0fa41d5dd827c3ea18e2.camel@sipsolutions.net>
Subject: Re: [PATCH 35/76] wifi: mac80211: mlme: use
 ieee80211_get_link_sband()
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Wen Gong <quic_wgong@quicinc.com>, linux-wireless@vger.kernel.org
Date:   Tue, 27 Sep 2022 10:15:57 +0200
In-Reply-To: <509e18bd-3004-9db5-459c-1935ee4eba5f@quicinc.com>
References: <20220713094502.163926-1-johannes@sipsolutions.net>
         <20220713114425.35973aa556f0.I1394dd82298f09c6cb452be538dba8ba13f11b01@changeid>
         <509e18bd-3004-9db5-459c-1935ee4eba5f@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-1.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Wed, 2022-09-14 at 18:00 +0800, Wen Gong wrote:
> On 7/13/2022 5:44 PM, Johannes Berg wrote:
> > From: Johannes Berg <johannes.berg@intel.com>
> >=20
> > This requires a few more changes.
> >=20
> > While at it, also add a warning to ieee80211_get_sband()
> > to avoid it being used when there are multiple links.
> >=20
> > Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> > ---
> >   net/mac80211/ieee80211_i.h |  2 ++
> >   net/mac80211/mlme.c        | 12 ++++++------
> >   2 files changed, 8 insertions(+), 6 deletions(-)
> >=20
> > diff --git a/net/mac80211/ieee80211_i.h b/net/mac80211/ieee80211_i.h
> > index 3e360bcaa03b..a0743c78d171 100644
> > --- a/net/mac80211/ieee80211_i.h
> > +++ b/net/mac80211/ieee80211_i.h
> > @@ -1539,6 +1539,8 @@ ieee80211_get_sband(struct ieee80211_sub_if_data =
*sdata)
> >   	struct ieee80211_chanctx_conf *chanctx_conf;
> >   	enum nl80211_band band;
> >  =20
> > +	WARN_ON(sdata->vif.valid_links);
> > +
> >   	rcu_read_lock();
> >   	chanctx_conf =3D rcu_dereference(sdata->vif.bss_conf.chanctx_conf);
> >  =20
> Hi Johannes,
>=20
> Now I hit below warning here in ieee80211_get_sband() in my MLO test for=
=20
> station.
> Will you have more patch to fix the warning?
>=20

Yeah still working on all this, obviously ...

That should be fairly harmless for now, unless you're trying to use 1k
block-ack.

johannes