Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH] wifi: ath11k: stop tx queues immediately upon firmware
 exit
From:   Kalle Valo <kvalo@kernel.org>
In-Reply-To: <20220923170235.18873-1-quic_adisi@quicinc.com>
References: <20220923170235.18873-1-quic_adisi@quicinc.com>
To:     Aditya Kumar Singh <quic_adisi@quicinc.com>
Cc:     <ath11k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
        Aditya Kumar Singh <quic_adisi@quicinc.com>
User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3
Message-ID: <166435109959.3623.15599848077820461188.kvalo@kernel.org>
Date:   Wed, 28 Sep 2022 07:45:02 +0000 (UTC)
Precedence: bulk

Aditya Kumar Singh <quic_adisi@quicinc.com> wrote:

> Currently, recovery flag is set immediately upon firmware
> exit but tx queues are stopped once firmware arrives back
> and is ready which is during ath11k_core_restart. Once
> ieee80211 hw restart is completed, tx queues are resumed.
> If during the time delta between firmware exit and firmware
> ready, mac80211 send packets, currently ath11k will drop it
> since recovery flag will be set. But warning prints will
> come -
>   "ath11k c000000.wifi: failed to transmit frame -108"
> 
> If more tx packets are there, this could lead to flooding
> of above print.
> 
> However, actually tx queues should be stopped immediately
> when firmware leaves. This will prevent packets to get
> dropped when firmware is recovering.
> 
> Add fix to stop tx queues immediately after firmware exit.
> 
> Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.5.0.1-01100-QCAHKSWPL_SILICONZ-1
> 
> Signed-off-by: Aditya Kumar Singh <quic_adisi@quicinc.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>

Patch applied to ath-next branch of ath.git, thanks.

81e60b2dfb27 wifi: ath11k: stop tx queues immediately upon firmware exit

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20220923170235.18873-1-quic_adisi@quicinc.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches