Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b8af19f6-564e-d592-0993-6b4c33728ac4@gmail.com>
Date:   Wed, 28 Sep 2022 20:53:36 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH v2] wifi: rtl8xxxu: Support new chip RTL8188FU
Content-Language: en-US
To:     Kalle Valo <kvalo@kernel.org>
Cc:     linux-wireless@vger.kernel.org,
        Jes Sorensen <Jes.Sorensen@gmail.com>, chris.chiu@canonical.com
References: <dfc6a877-e50a-87a2-08f7-7007c8083386@gmail.com>
 <87bkr27amy.fsf@kernel.org>
From:   Bitterblue Smith <rtl8821cerfe2@gmail.com>
In-Reply-To: <87bkr27amy.fsf@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 26/09/2022 12:22, Kalle Valo wrote:
> Bitterblue Smith <rtl8821cerfe2@gmail.com> writes:
> 
> [...]
> 
>> +static struct rtl8xxxu_reg8val rtl8188f_mac_init_table[] = {
> 
> [...]
> 
>> +static struct rtl8xxxu_reg32val rtl8188fu_phy_init_table[] = {
> 
> [...]
> 
>> +static struct rtl8xxxu_reg32val rtl8188f_agc_table[] = {
> 
> [...]
> 
>> +static struct rtl8xxxu_rfregval rtl8188fu_radioa_init_table[] = {
> 
> [...]
> 
>> +static struct rtl8xxxu_rfregval rtl8188fu_cut_b_radioa_init_table[] = {
> 
> Can these arrays be static const?
> 
Only if I modify the functions rtl8xxxu_init_phy_regs and
rtl8xxxu_init_phy_rf, and the struct rtl8xxxu_fileops. Otherwise the
compiler complains about discarded const. Perhaps in a future patch?

I implemented everything else you mentioned.