Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp1641937rwb; Wed, 28 Sep 2022 23:30:18 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6Z9O72JJplrDpvayVFZyTvpypHSwEsI+xwy6hKZLM4TNHFn7vsFi15ekgwkgdCe6Ts4rpw X-Received: by 2002:a17:907:3da0:b0:787:89cc:faab with SMTP id he32-20020a1709073da000b0078789ccfaabmr1366008ejc.92.1664433018627; Wed, 28 Sep 2022 23:30:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664433018; cv=none; d=google.com; s=arc-20160816; b=i96Ip1Nk9wi/9HH5xTeX64hNIBgd33nu0iyT8fYJz9t23a4Am2pgClykh7Qwvv4Ena 5iV9b713U8YbNufUL/BW271Ic2g6PH2snRSINE+DawP+jiby9nG8Hncc2C621dT24T9q UdjOHNVtYaIYbHi+0KyiFXk1+OEneIO6v30kf4KL7nKEM8sF0dM26b/FS5gA1T4NVHZb obyNYR6cO7QpuF6LLcS7HH6vur5bzy5NLTVnBivKmx912JzjcXZIN0I9SlSDGgUXOr9+ v/pIFEcInEenzp/scdc7BHnDwx8G+wkeYrMIR0DBL7xpYl4BnSeHXQbETdvUAlzCD9XX O7Dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dkim-signature; bh=4ZFezsI2NYvblHAAE8UKFKPQLcW/ac4DhcwCSHOc5ho=; b=mK0C0cf4Gm74eP7SgBtnA5cXmZC8mRZ0aAoMWku5JJrvl6OVdj8OlPAg8kwUMJsnHG GY7tvGubXadgROUyxTFO5/DoFbVVhqWc3+gz9qYyw69kcvjfNcgG2xRMhG09bjodfUwb TyApLEQUuXpkhh+9XJA+LHXzKn51uMw95Jy6BHEhPI/gbxK5dAJsbaHMN3wGALsCoUS6 VJ3ZQ2cs9IPT2qvFkP86X6qu2sdQW09uKuDU+GNXYm8+iYKhupk3ImsA/GHL+t1sQcGz tWiJAxRb07rp8GsVfD1nLxO+MnU9getSDTr+J8FgDiyTtwVifBDYi9EqU3vYBx5FSFjW dP+g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=CgQCJiyl; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id xe1-20020a170907318100b00730bc62507csi7192954ejb.125.2022.09.28.23.30.02; Wed, 28 Sep 2022 23:30:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=CgQCJiyl; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234729AbiI2GXw (ORCPT + 59 others); Thu, 29 Sep 2022 02:23:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234666AbiI2GXv (ORCPT ); Thu, 29 Sep 2022 02:23:51 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27F1812969D for ; Wed, 28 Sep 2022 23:23:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B80376202F for ; Thu, 29 Sep 2022 06:23:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1F724C433D7; Thu, 29 Sep 2022 06:23:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664432630; bh=gGVKnk5tdrKF7EF6Tn/YMG+mjTSIhDxU33qoCsKVtqQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=CgQCJiylIILmpxDhSzqtk3etl6d4TpPObcG2ftHEiyqwAx8Kqp8/WYnshvJO8x62Y jPNPrh1Hf5JcWVLTWSURHTPln2l93SNF/qIXzghcaj8el2NpKS6Jv6ZiY2qj1jDwsl +53gcAgv1ogVPmsy8M6KB0Zf1IcDXnk6hXEUouUwAKtq03dX/LScPdis8iWSkE5gWi cTUWUf+D5Jf9i4KMYDSbZzSC8kyDuILKCLSndRPFLRjQNNEComftPvgRmeuIoWI+Fa H6i/XMFwls1u0Rd8qhIYkMpvHG6qXz4SeqasevFbgUQHb5FsvsC5TmYUf2uqGHHJfE fOojOnP0msr4A== From: Kalle Valo To: Bitterblue Smith Cc: linux-wireless@vger.kernel.org, Jes Sorensen , chris.chiu@canonical.com Subject: Re: [PATCH v2] wifi: rtl8xxxu: Support new chip RTL8188FU References: <87bkr27amy.fsf@kernel.org> Date: Thu, 29 Sep 2022 09:23:46 +0300 In-Reply-To: (Bitterblue Smith's message of "Wed, 28 Sep 2022 20:53:36 +0300") Message-ID: <87v8p6r959.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Bitterblue Smith writes: > On 26/09/2022 12:22, Kalle Valo wrote: > >> Bitterblue Smith writes: >> >> [...] >> >>> +static struct rtl8xxxu_reg8val rtl8188f_mac_init_table[] = { >> >> [...] >> >>> +static struct rtl8xxxu_reg32val rtl8188fu_phy_init_table[] = { >> >> [...] >> >>> +static struct rtl8xxxu_reg32val rtl8188f_agc_table[] = { >> >> [...] >> >>> +static struct rtl8xxxu_rfregval rtl8188fu_radioa_init_table[] = { >> >> [...] >> >>> +static struct rtl8xxxu_rfregval rtl8188fu_cut_b_radioa_init_table[] = { >> >> Can these arrays be static const? >> > Only if I modify the functions rtl8xxxu_init_phy_regs and > rtl8xxxu_init_phy_rf, and the struct rtl8xxxu_fileops. Otherwise the > compiler complains about discarded const. Perhaps in a future patch? Yeah, a future patch sounds good. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches