Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp3216353rwb; Thu, 29 Sep 2022 23:43:13 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6+PT49/kQSXit5i0Zjn/uz1eUBpErzfYeKyyL1GCOwBE9u0hQ08GLb7NnfLeE8NzjXGBBF X-Received: by 2002:a05:6402:26d6:b0:451:24da:f8cf with SMTP id x22-20020a05640226d600b0045124daf8cfmr6729145edd.385.1664520193645; Thu, 29 Sep 2022 23:43:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664520193; cv=none; d=google.com; s=arc-20160816; b=qogNUWotj8qohfbuWF7DRQB3Pfa7j7a1eceTPOL5xxhNET0LruPHtE4qI4DNPSj2L5 ND67l/s5xXNGo9SCLWPIVlcmx/l7+FATLraOEyaipMquwbwUUDZsPw0696DTgx6y82tb XlNaMDtJ78cFSlo20EnT7GaRGiNNCEu43wfqKm6k83/kJYOMBBEe8wRE04MF5xl2tAai IrUMiFGGOTqQyjwPm4MliGX8LhXmOT7ICSPlHUb5cMRDlBCEdPblPo1o02+DIOeQN0l5 UORmSiFPYLIq88HVTsPsCJYCLcAI9jXcFkIWlaXL8+cjdt7ufKpkagZ/JPnTu4EQKzlg 89rA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=bMsezmXmujttQ8WN2RnbKQlBU/v3Qok9KnaEIw+OVMc=; b=Uonxj+whDO226QmqTXdUWD/eGfZJbiY3CB+3JaR64VLTrNt7B2y7BF64+uoFWBkq9Y w1DGhepCmDRR7JdatDSvMtWherPjQIHQTiDH3aLy+JWyxOZ82wH4eP9q3R7c5zUwA3a4 nyuibkYhTvFNMamv0vHs7uEg+OqwR/5NAN0LTG8bje/ecA23FL6wEa/Mq3n21KHNOTx5 JC6W+do4D+UhunvXQhejpjaGY8BeknHNVYBRIuteRxpCmVnSy6WS8izoAYNDt9jceFCY RVJTm5S48QN5YC6yQ45z+ijW8smybiCywaP9cm8q4MajGheKe8+k+Q0xxy3wySZn+SgK 1/uw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=bDJJnYEq; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ga27-20020a1709070c1b00b00773b8e3d83bsi1362678ejc.323.2022.09.29.23.42.58; Thu, 29 Sep 2022 23:43:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=bDJJnYEq; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230339AbiI3GdT (ORCPT + 59 others); Fri, 30 Sep 2022 02:33:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230284AbiI3GdR (ORCPT ); Fri, 30 Sep 2022 02:33:17 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE3341F65DC for ; Thu, 29 Sep 2022 23:33:16 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 610C0B82455 for ; Fri, 30 Sep 2022 06:33:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 532F4C433C1; Fri, 30 Sep 2022 06:33:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664519594; bh=AjE9ttVTxQyrvvGBjQ3K8rHuqcgBsgTiY5i7Op2lqCk=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=bDJJnYEqYzM4l65RDTROm+w8PISHo921Ac6jWMvAarrMre1y3XGMVkt3JS629UAxx VwU/rZ8Z7ZNC7S2ikUdOXGTkxe0fOZ4m6LuwiY2jDdXuh7DoLFwL0lCVoSP2MSWwT6 oJSftY0DVGukgk/S9lbFfTkPgnIp6nGZtZE6qtQfu8pXj3QNjeycpL9vPMLy3SePyi w8BI5IOB7TXo+a5z3aVdDtcS+JKkJ3LKcfwIF2qOVKd4xkdtN838QQBHWVt5QCBjTn J9nQ0Nqvi5u2ADHM5JRWLlCid7HMwBTexGVjwyKtW0CCjJXqt+abEioOZYCLjTB+gR byspQAAaE/hBQ== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wifi: ath11k: Don't exit on wakeup failure From: Kalle Valo In-Reply-To: <20220928015140.5431-1-quic_bqiang@quicinc.com> References: <20220928015140.5431-1-quic_bqiang@quicinc.com> To: Baochen Qiang Cc: , User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <166451959112.6083.18119896187567020828.kvalo@kernel.org> Date: Fri, 30 Sep 2022 06:33:13 +0000 (UTC) X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Baochen Qiang wrote: > Currently, ath11k_pcic_read() returns an error if wakeup() > fails, this makes firmware crash debug quite hard because we can > get nothing. > > Change to go ahead on wakeup failure, in that case we still may > get something valid to check. There should be no mislead due > to incorrect content because we are aware of the failure with the > log printed. > > Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-01720.1-QCAHSPSWPL_V1_V2_SILICONZ_LITE-1 > > Signed-off-by: Baochen Qiang > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 45d2e268369b wifi: ath11k: Don't exit on wakeup failure -- https://patchwork.kernel.org/project/linux-wireless/patch/20220928015140.5431-1-quic_bqiang@quicinc.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches