Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <98c184b456e0dc1b0bb59f2e479e1739f4dbed79.camel@sipsolutions.net>
Subject: Re: [PATCH] wifi: mac80211: Use internal TX queues for all drivers
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Alexander Wetzel <alexander@wetzel-home.de>,
        linux-wireless@vger.kernel.org
Date:   Fri, 30 Sep 2022 11:41:52 +0200
In-Reply-To: <79161904-1e56-3046-b381-705e4af11e84@wetzel-home.de>
References: <20220926161303.13035-1-alexander@wetzel-home.de>
         <da810136f6cf0608167cc8297ce73d11b83974d6.camel@sipsolutions.net>
         <79161904-1e56-3046-b381-705e4af11e84@wetzel-home.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Fri, 2022-09-30 at 11:08 +0200, Alexander Wetzel wrote:
> On 29.09.22 22:40, Johannes Berg wrote:
> > Thanks for doing this!
> >=20
> > It's a bit bad timing right now, so I'll only have a chance to look at
> > this in the next couple of weeks, but that also doesn't matter that muc=
h
> > since 6.0 release is imminent (will likely be Sunday).
> >=20
>=20
> Thanks for the warning. I'll then send a v2 to correct skb_get_hash()=20
> handling in the next days.

I probably won't merge it much before ~2 weeks from now, so take your
time :)

> The general plan so far is, to move everything to iTXQ first and then=20
> see what we an throw out. I'll prepare a patch cleaning up that a bit=20
> more. Don't think that will be much at this stage, so maybe I just add=
=20
> that into the v2 of the patch...

No, separate patches are fine - was more wondering if you were planning
to do it, or if I should think about finding someone else ;-)

> I'm basically working with the plan you outlined some years ago:
> https://lore.kernel.org/linux-wireless/1507217947.2387.60.camel@sipsoluti=
ons.net/

:)
I can't even remember it that much, to be honest.

> It just turned out to be simpler to start with unifying the TX paths.

Makes sense.

Thanks!

johannes