Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp568447rwb; Sat, 1 Oct 2022 04:57:50 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5apqGXj+vtwfTfsen5Y7IA3YK712Np5zH8MrNzrs6DU0Uoom6/7CoxtPMdvxSjrIHh09aj X-Received: by 2002:a17:90b:4b44:b0:202:562a:b8c0 with SMTP id mi4-20020a17090b4b4400b00202562ab8c0mr3023093pjb.99.1664625470434; Sat, 01 Oct 2022 04:57:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664625470; cv=none; d=google.com; s=arc-20160816; b=0Qu5d3TrlbiqeWQqcNgqojPkoaVVGWF7RGQ37V+suMylpU2vbo+vvv9FXrbZ9CCU3g Xy97M4DWinANTYZHi+tnh3vPQUM51upUgy6/+Od2BGP5lleaj/WJWf3YQGNE4FgOmLmp C6Q4n1W8RQe3Tu6YdO69/naBLr41IKK7RUOrYpO3g/5J6q2vKTM2DNm2n4vd/yOTP/8h j7a3bOTnSSjL/Pz1C7it3e0481/ZzCQcNHypJUUHpiFTtcaV72q+20IIgsmHblkz3Hbz AVXGUR2t4MZMsUX2D2cmiFvzc7KgeXTEztNP3jY1GM0OoOLowG3BkenF/5Tm8LourlQt 29uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:dkim-signature; bh=7paJOERXZr9gpWv6Hoqqnji80Lwp5u+xWWySpJyrP6s=; b=vWY3KWZBMCOtVc0vdw86Bw6bW9I51p2rrBSwt76C/Y9FWBolK6To2yED/sIuNXOvor XBwrg4iMMj6vIM8mMfiGd6cT6wQHNkjPXSxp8ScezQJd2vPAsOuX9WjBFA7/kPm26PKH ir2lyBjoMxKRQ/vbVhRYWZ8xgI7wmTfwNLCsHn0xmfJxNd4xTa5oQNkyPKLZMxVvyQgc r5FZxGROADzqmYP+jhRqHp24xSa0rf8+9VJb2idhlaZB0g2SKNbrhkHmNBCZwH7lhtnt b1JHYK8gPcuBeNHxPvrxQhsVdWSeyyou437ZVorxl8ZllA/XPFtFDC93OfKTtArvJKRs sLBg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@nbd.name header.s=20160729 header.b=TNZTwFno; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nbd.name Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s5-20020a170902ea0500b00176d89d640asi6161827plg.440.2022.10.01.04.57.33; Sat, 01 Oct 2022 04:57:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@nbd.name header.s=20160729 header.b=TNZTwFno; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nbd.name Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229600AbiJALom (ORCPT + 59 others); Sat, 1 Oct 2022 07:44:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229441AbiJALol (ORCPT ); Sat, 1 Oct 2022 07:44:41 -0400 Received: from nbd.name (nbd.name [46.4.11.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CCA06DDF for ; Sat, 1 Oct 2022 04:44:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbd.name; s=20160729; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=7paJOERXZr9gpWv6Hoqqnji80Lwp5u+xWWySpJyrP6s=; b=TNZTwFnoNm2sOzqgTiCmdFBZLx 2SvyVDMKesbhxwsexjrZUixyveCMV9S2pd0ZMopipUVAkyQRXWc7gl43gIQCd89r7L1fRmaPB3eJn xal9iYu+Lwy2hUVjLu3cuXTSeq9I6O5WqKlyMTjs6Ws95lXDUqtFGIBJ1BBxZPFEMYFk=; Received: from p200300daa7301d00cc0df67a5b51dd3e.dip0.t-ipconnect.de ([2003:da:a730:1d00:cc0d:f67a:5b51:dd3e] helo=nf.local) by ds12 with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1oeav5-009DLv-V6; Sat, 01 Oct 2022 13:44:36 +0200 Message-ID: Date: Sat, 1 Oct 2022 13:44:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH 2/2] wifi: mt76: mt7915: add two additional errors to ack-failure mask. To: greearb@candelatech.com, linux-wireless@vger.kernel.org References: <20220929151526.9559-1-greearb@candelatech.com> <20220929151526.9559-2-greearb@candelatech.com> Content-Language: en-US From: Felix Fietkau In-Reply-To: <20220929151526.9559-2-greearb@candelatech.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 29.09.22 17:15, greearb@candelatech.com wrote: > From: Ben Greear > > These other two bits also indicate tx failure as far as I can tell from > reading the documents. > > Signed-off-by: Ben Greear The bits seem to have overlapping meaning, not sure if they always reliably indicate an error. I think we should leave this patch out, as it could potentially cause regressions. - Felix