Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kalle Valo <kvalo@kernel.org>
To:     Ian Lin <ian.lin@infineon.com>
Cc:     <linux-wireless@vger.kernel.org>,
        <brcm80211-dev-list@broadcom.com>,
        <brcm80211-dev-list@cypress.com>, <franky.lin@broadcom.com>,
        <hante.meuleman@broadcom.com>, <Double.Lo@infineon.com>
Subject: Re: [PATCH 1/3] brcmfmac: add a timer to read console periodically in PCIE bus
References: <20220929031001.9962-1-ian.lin@infineon.com>
        <20220929031001.9962-2-ian.lin@infineon.com>
Date:   Tue, 04 Oct 2022 10:07:26 +0300
In-Reply-To: <20220929031001.9962-2-ian.lin@infineon.com> (Ian Lin's message
        of "Wed, 28 Sep 2022 22:09:59 -0500")
Message-ID: <87edvoqd75.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Ian Lin <ian.lin@infineon.com> writes:

> From: Wright Feng <wright.feng@cypress.com>
>
> Currently, host only reads console buffer when receiving mailbox data or
> hit crash with PCIE bus. Therefore, we add timer in PCIE code to read
> console buffer periodically to help developer and user check firmware
> message when there is no data transmission between host and dongle.
>
> Signed-off-by: Wright Feng <wright.feng@cypress.com>
> Signed-off-by: Chi-hsien Lin <chi-hsien.lin@cypress.com>
> Signed-off-by: Ian Lin <ian.lin@infineon.com>

[...]

> @@ -340,6 +342,11 @@ struct brcmf_pciedev_info {
>  			  u16 value);
>  	struct brcmf_mp_device *settings;
>  	struct brcmf_otp_params otp;
> +#ifdef DEBUG
> +	u32 console_interval;
> +	bool console_active;
> +	struct timer_list timer;
> +#endif
>  };

I was wondering where that DEBUG is defined and found that it's done in
the Makefile:

subdir-ccflags-$(CONFIG_BRCMDBG)	+= -DDEBUG

I think that DEBUG define should be removed and instead CONFIG_BRCMDBG
should be used all over the brcmfmac and brcmsmac code. A cleanup patch
doing this is very welcome.

This would be a good task for someone new to kernel development, is
there a way to report these kind of simple tasks?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches