Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <62b8bf6f739d1e6e0320864ed0660c9c52b767c4.camel@sipsolutions.net>
Subject: Re: doc warnings in *80211
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        linux-wireless@vger.kernel.org
Date:   Tue, 04 Oct 2022 09:51:07 +0200
In-Reply-To: <20221003191128.68bfc844@kernel.org>
References: <20221003191128.68bfc844@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) 
MIME-Version: 1.0
Precedence: bulk

Hi,

> doing basic sanity checks before submitting the net-next PR I spotted
> that we have these warnings when building documentation on net-next:
>=20
> Documentation/driver-api/80211/cfg80211:48: ./include/net/cfg80211.h:6960=
: WARNING: Duplicate C declaration, also defined at driver-api/80211/cfg802=
11:6924.
> Declaration is '.. c:function:: void cfg80211_rx_assoc_resp (struct net_d=
evice *dev, struct cfg80211_rx_assoc_resp *data)'.

Hmm. That's interesting. I guess it cannot distinguish between the type
of identifier?

struct cfg80211_rx_assoc_resp vs. cfg80211_rx_assoc_resp()

Not sure what do about it - rename one of them?

> Documentation/driver-api/80211/mac80211:109: ./include/net/mac80211.h:504=
6: WARNING: Duplicate C declaration, also defined at driver-api/80211/mac80=
211:1065.
> Declaration is '.. c:function:: void ieee80211_tx_status (struct ieee8021=
1_hw *hw, struct sk_buff *skb)'.

Same here actually!

I don't think either of these is new.

johannes