Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp121584rwb; Tue, 4 Oct 2022 01:19:31 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5+0l5abs4saNfdbVWgWeMQ0evvPBFXKkiW2I+t30I8EJ1JIzn8HuAlzwSZnpH/DFc6THNz X-Received: by 2002:a17:90b:4a52:b0:20a:c8e6:477f with SMTP id lb18-20020a17090b4a5200b0020ac8e6477fmr4266627pjb.219.1664871571294; Tue, 04 Oct 2022 01:19:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664871571; cv=none; d=google.com; s=arc-20160816; b=jT5E9EftI8vLdJ8rNm3Iwy3Q8pr3y1kGhAKOdYZE60RtZmkZ1sxYDprofK/jhqL30n 7gOJzrb41nGyMyBkA95fuh8eZy/gOAL3RuOLpLK4wREwYOsnHiMu1PqajvLgvCYt7YBZ jVe3WsL1ig7Xr4Se14t7zl7TydvTUQE343GJyXUaxm23Q31LKSp205clrr8oerk5vine SdK5nSoGzejcd/Ql1MOasPu2UJP9CncdbZRxnSO7sNyMrcUOQJB9tO8zeGOUxYbp/2Tw fd1P8dhZCh8py4Nld/OMR4fIKrWj1coKucfR6mI6FuQY/xCQlHfz3Q7tYKMWzixwYIbw ntHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=VeyFBkbhWm3HuTRT54mfPrcxXVP70Hoccn5pI3U1J1s=; b=QPVdhiCy/uGx5T8vr7SWkFux6ITxL9yu93Txo1KaObuwW6ZADslMAlCD41D8FJlOb6 W4sTNN5iW//YjogW8JtCNwE0cuH52+bnym+KWC0m++gwnRl+WDd8hBQL3Zp4HrlvqGdg tCYR9nUSPsfuIdv5mv9rSXFnumDaT9wUYfITLlUtDF02mzkfOXf1XufV5p0o2datDewY ajKJ4AbJwSyKKDYonR5V3f0hB40l223r95eswAKRQcIhsaIZZMMFNzFoKIMaLL4EwumA WCWudK0JHrvmrcMRszym2cPuildJ/LycqhStvQk1tbGlIkxgAcOh3bmtA+SPUJHr8Qtf sT5Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=esilWYNW; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mw6-20020a17090b4d0600b00200ab48e149si2404287pjb.72.2022.10.04.01.19.22; Tue, 04 Oct 2022 01:19:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=esilWYNW; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229988AbiJDISz (ORCPT + 60 others); Tue, 4 Oct 2022 04:18:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230040AbiJDISU (ORCPT ); Tue, 4 Oct 2022 04:18:20 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC29E6149 for ; Tue, 4 Oct 2022 01:18:19 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 78F7561290 for ; Tue, 4 Oct 2022 08:18:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 22587C433D6; Tue, 4 Oct 2022 08:18:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664871498; bh=ATpIqvbT+eZEBC5fPb02OC2jEVWqFdvYpwX8o0ciNtY=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=esilWYNW/fKWy23r1WBLhq6ub334yR/vDgQ8xMD+vYL8eNnV2Z4HFUEapGokVqwtA j/2oc2SNLmqYrRKOI3uabeZkSgpqY2nRmKykEK07QFEG197d5qgE83ifbasSfcxgb9 60WwV/hfAaMbFFyQ4sFauuRUioIUO0wla7Tiwki/O55uSHAH/7jxSgBvsWp1ajEN+h hVyPsuwBDEz++ow4RB8IRAp/knWARJKfmKDz50zr5pnto0XcssoAInN/FtXt40b/1w cz0EcUTW4noHJN7yp6gZeW/0h/aqgM0k22BUKV4F2YiB5MkHxfkOTP58xQeSr0K3kp m2H0BHe2wNQog== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH v2] wifi: rtl8xxxu: gen2: Turn on the rate control From: Kalle Valo In-Reply-To: <43200afc-0c65-ee72-48f8-231edd1df493@gmail.com> References: <43200afc-0c65-ee72-48f8-231edd1df493@gmail.com> To: Bitterblue Smith Cc: linux-wireless@vger.kernel.org, Jes Sorensen User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <166487149459.9318.3375191834985088151.kvalo@kernel.org> Date: Tue, 4 Oct 2022 08:18:17 +0000 (UTC) X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Bitterblue Smith wrote: > Re-enable the function rtl8xxxu_gen2_report_connect. > > It informs the firmware when connecting to a network. This makes the > firmware enable the rate control, which makes the upload faster. > > It also informs the firmware when disconnecting from a network. In the > past this made reconnecting impossible because it was sending the > auth on queue 0x7 (TXDESC_QUEUE_VO) instead of queue 0x12 > (TXDESC_QUEUE_MGNT): > > wlp0s20f0u3: send auth to 90:55:de:__:__:__ (try 1/3) > wlp0s20f0u3: send auth to 90:55:de:__:__:__ (try 2/3) > wlp0s20f0u3: send auth to 90:55:de:__:__:__ (try 3/3) > wlp0s20f0u3: authentication with 90:55:de:__:__:__ timed out > > Probably the firmware disables the unnecessary TX queues when it > knows it's disconnected. > > However, this was fixed in commit edd5747aa12e ("wifi: rtl8xxxu: Fix > skb misuse in TX queue selection"). > > Fixes: c59f13bbead4 ("rtl8xxxu: Work around issue with 8192eu and 8723bu devices not reconn…") > Signed-off-by: Bitterblue Smith Patch applied to wireless-next.git, thanks. c5ef1cee5745 wifi: rtl8xxxu: gen2: Turn on the rate control -- https://patchwork.kernel.org/project/linux-wireless/patch/43200afc-0c65-ee72-48f8-231edd1df493@gmail.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches