Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kalle Valo <kvalo@kernel.org>
To:     Bitterblue Smith <rtl8821cerfe2@gmail.com>
Cc:     linux-wireless@vger.kernel.org,
        Jes Sorensen <Jes.Sorensen@gmail.com>
Subject: Re: [PATCH v2] wifi: rtl8xxxu: gen2: Turn on the rate control
References: <43200afc-0c65-ee72-48f8-231edd1df493@gmail.com>
        <166487149459.9318.3375191834985088151.kvalo@kernel.org>
Date:   Tue, 04 Oct 2022 11:23:33 +0300
In-Reply-To: <166487149459.9318.3375191834985088151.kvalo@kernel.org> (Kalle
        Valo's message of "Tue, 4 Oct 2022 08:18:17 +0000 (UTC)")
Message-ID: <87lepw575m.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Kalle Valo <kvalo@kernel.org> writes:

> Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote:
>
>> Re-enable the function rtl8xxxu_gen2_report_connect.
>>=20
>> It informs the firmware when connecting to a network. This makes the
>> firmware enable the rate control, which makes the upload faster.
>>=20
>> It also informs the firmware when disconnecting from a network. In the
>> past this made reconnecting impossible because it was sending the
>> auth on queue 0x7 (TXDESC_QUEUE_VO) instead of queue 0x12
>> (TXDESC_QUEUE_MGNT):
>>=20
>> wlp0s20f0u3: send auth to 90:55:de:__:__:__ (try 1/3)
>> wlp0s20f0u3: send auth to 90:55:de:__:__:__ (try 2/3)
>> wlp0s20f0u3: send auth to 90:55:de:__:__:__ (try 3/3)
>> wlp0s20f0u3: authentication with 90:55:de:__:__:__ timed out
>>=20
>> Probably the firmware disables the unnecessary TX queues when it
>> knows it's disconnected.
>>=20
>> However, this was fixed in commit edd5747aa12e ("wifi: rtl8xxxu: Fix
>> skb misuse in TX queue selection").
>>=20
>> Fixes: c59f13bbead4 ("rtl8xxxu: Work around issue with 8192eu and 8723bu=
 devices not reconn=E2=80=A6")
>> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
>
> Patch applied to wireless-next.git, thanks.
>
> c5ef1cee5745 wifi: rtl8xxxu: gen2: Turn on the rate control

Please disregard the commit id, the fixes tag is incorrect so I need to
apply it again to fix it.

In commit

  c5ef1cee5745 ("wifi: rtl8xxxu: gen2: Turn on the rate control")

Fixes tag

  Fixes: c59f13bbead4 ("rtl8xxxu: Work around issue with 8192eu and
  8723bu devices not reconn=E2=80=A6")

has these problem(s):

  - Subject does not match target commit subject
      Just use
           git log -1 --format=3D'Fixes: %h ("%s")'
=20=20=20=20=20=20=20=20=20=20=20

--=20
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc=
hes