Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c02248328c5bd4bee1d0dbb4e6eccecb1d1a13e0.camel@sipsolutions.net>
Subject: Re: [PATCH] iw: info: print PMSR capabilities
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Jaewan Kim <jaewan@google.com>
Cc:     linux-wireless@vger.kernel.org
Date:   Wed, 05 Oct 2022 11:47:50 +0200
In-Reply-To: <20220923015550.1292547-1-jaewan@google.com>
References: <20220923015550.1292547-1-jaewan@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Fri, 2022-09-23 at 10:55 +0900, Jaewan Kim wrote:
>=20
> +#define PRINT_FTM_U8(T, NAME) \
> +	do { \
> +		if (T[NL80211_PMSR_FTM_CAPA_ATTR_##NAME]) \
> +			printf("\t\t\t" #NAME "=3D\n", \
> +				nla_get_u8(T[NL80211_PMSR_FTM_CAPA_ATTR_##NAME])); \

This doesn't compile, and there are also a few compiler warnings.

That's all easy to fix, but it does make me wonder if you tested this at
all, or accidentally sent out an unfixed version from before testing, or
so?

johannes