Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6d0333ef30624ef285c01dc2dd27da76450d613e.camel@sipsolutions.net>
Subject: Re: [PATCH 05/28] wifi: cfg80211: support reporting failed links
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Veerendranath Jakkam <quic_vjakkam@quicinc.com>
Cc:     linux-wireless@vger.kernel.org
Date:   Thu, 06 Oct 2022 13:11:07 +0200
In-Reply-To: <13b44ce9-e000-cdcf-c057-b176edb6d31f@quicinc.com>
References: <20221005145226.2224328320e7.I53966b9c7572fe1a08a7dc02ed29be9e1b0467fc@changeid>
         <0e354734-6f6b-8170-b453-e699fc9962e5@quicinc.com>
         <0fd2932c29adcc6be5fe5528d297b7deb0e0617b.camel@sipsolutions.net>
         <13b44ce9-e000-cdcf-c057-b176edb6d31f@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Thu, 2022-10-06 at 16:39 +0530, Veerendranath Jakkam wrote:
> On 10/6/2022 4:21 PM, Johannes Berg wrote:
> > On Thu, 2022-10-06 at 16:19 +0530, Veerendranath Jakkam wrote:
> > > I think similar enhancement needed for cfg80211_roamed/NL80211_CMD_RO=
AM
> > > also to know accepted and rejected links info during roaming.
> > >=20
> > Not sure, in that case we might care only about the successful links
> > since wpa_s didn't request the others, so maybe it doesn't matter?
>=20
> Drivers can offload EAPOL 4WHS to wpa_supplicant during roaming with=20
> non-FT AKMs. In that case supplicant needs to know rejected links info=
=20
> to validate AP's MLO Link KDEs in 3/4 frame.
>=20
> Ex: Driver handles only re-association request and response frames while=
=20
> doing roaming with non-FT AKM then offload 4WHS to wpa_supplicant
>=20

Right, but is there a fundamental difference between

 "hey I roamed to this AP MLD with links 1, 2 and 5"
 (with the right BSSIDs for the links etc.)

and

 "hey I roamed to this AP MLD and I tried links 1, 2, 3, 4, 5 but only
1, 2 and 5 were established"

?

johannes