Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d837e231-7704-bdb0-4cc5-89a214d21d3c@quicinc.com>
Date:   Thu, 6 Oct 2022 20:10:55 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.1
Subject: Re: [PATCH 05/28] wifi: cfg80211: support reporting failed links
Content-Language: en-US
To:     Johannes Berg <johannes@sipsolutions.net>
CC:     <linux-wireless@vger.kernel.org>
References: <20221005145226.2224328320e7.I53966b9c7572fe1a08a7dc02ed29be9e1b0467fc@changeid>
 <0e354734-6f6b-8170-b453-e699fc9962e5@quicinc.com>
 <0fd2932c29adcc6be5fe5528d297b7deb0e0617b.camel@sipsolutions.net>
 <13b44ce9-e000-cdcf-c057-b176edb6d31f@quicinc.com>
 <6d0333ef30624ef285c01dc2dd27da76450d613e.camel@sipsolutions.net>
From:   Veerendranath Jakkam <quic_vjakkam@quicinc.com>
In-Reply-To: <6d0333ef30624ef285c01dc2dd27da76450d613e.camel@sipsolutions.net>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 10/6/2022 4:41 PM, Johannes Berg wrote:
> Right, but is there a fundamental difference between
>   "hey I roamed to this AP MLD with links 1, 2 and 5"
>   (with the right BSSIDs for the links etc.)
>
> and
>
>   "hey I roamed to this AP MLD and I tried links 1, 2, 3, 4, 5 but only
> 1, 2 and 5 were established"
>
> ?

supplicant must validate MLO Link KDEs(includes RSNE and RSNXE) for all 
the negotiated links but MLO GTK/IGTK/BIGTK only for accepted links 
while processing 3/4 msg.

So, during roaming if EAPOL 4HS is offload to supplicant it should know 
the requested and accepted links information.

non-AP MLD needs to select common AKM across all the links. The MLO Link 
KDEs validation helps to avoid downgrade attacks.

- veeru