Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3acec81e863aa5f184bc5a74916f1470b77552cb.camel@sipsolutions.net>
Subject: Re: [PATCH v4] ath9k: verify the expected usb_endpoints are present
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Fedor Pchelkin <pchelkin@ispras.ru>,
        Toke =?ISO-8859-1?Q?H=F8iland-J=F8rgensen?= <toke@toke.dk>,
        Kalle Valo <kvalo@kernel.org>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Alexey Khoroshilov <khoroshilov@ispras.ru>,
        lvc-project@linuxtesting.org,
        Alan Stern <stern@rowland.harvard.edu>
Date:   Sat, 08 Oct 2022 22:10:16 +0200
In-Reply-To: <20221008120211.24764-1-pchelkin@ispras.ru>
References: <20221008120211.24764-1-pchelkin@ispras.ru>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Sat, 2022-10-08 at 15:02 +0300, Fedor Pchelkin wrote:
> =20
> +	/* Verify the expected endpoints are present */
> +	alt =3D interface->cur_altsetting;
> +	if (usb_find_common_endpoints(alt, &bulk_in, &bulk_out, &int_in, &int_o=
ut) < 0 ||
> +			usb_endpoint_num(bulk_in) !=3D USB_WLAN_RX_PIPE ||
> +			usb_endpoint_num(bulk_out) !=3D USB_WLAN_TX_PIPE ||
> +			usb_endpoint_num(int_in) !=3D USB_REG_IN_PIPE ||
> +			usb_endpoint_num(int_out) !=3D USB_REG_OUT_PIPE) {
> +			dev_err(&udev->dev,
> +					"ath9k_htc: Device endpoint numbers are not the expected ones\n");
> +		return -ENODEV;
>=20

Indentation somehow got pretty messed up now ..

johannes