Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e9f0e3fb-3259-3d5b-de80-2a7a579a4440@wetzel-home.de>
Date:   Sun, 9 Oct 2022 20:34:35 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH v2 1/3] wifi: mac80211: add internal handler for
 wake_tx_queue
Content-Language: en-US
To:     linux-wireless@vger.kernel.org
Cc:     johannes@sipsolutions.net, toke@kernel.org
References: <20221009163040.25637-1-alexander@wetzel-home.de>
From:   Alexander Wetzel <alexander@wetzel-home.de>
In-Reply-To: <20221009163040.25637-1-alexander@wetzel-home.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

> Changes compared to V1:
>   - broken out the new wake_tx_queue handler as exported function
>   - update drivers to provide wake_tx_queue instead handling it internally
>   - Minor docu updates
>   - Some sentences of the edited docu were referring to wrong netif
>     functions. Fixed that with the edit, too.
>   - added a comment explaining why we call ieee80211_next_txq()
>   - removed now pointless checks for sta.txq
> 

Forgot to mention one change:
skb_get_hash() is now always called. I moved it into 
ieee80211_select_queue() to address the issue Toke had with outright 
dropping it in v1.

Alexander