Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp62825rwi; Sun, 9 Oct 2022 18:32:37 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7ojHohizEuGFZ5h+LuxM6pWa/fnc/P2zcQpbcxtkZLMiksey8xUsRozZ9SYX0mZYgHEvEd X-Received: by 2002:a17:902:d502:b0:177:f287:269d with SMTP id b2-20020a170902d50200b00177f287269dmr16849541plg.140.1665365556897; Sun, 09 Oct 2022 18:32:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665365556; cv=none; d=google.com; s=arc-20160816; b=knUYMbM0g3epyG5WdF8c0fOrIar1UOMiTw+oE5PTFVvOAnvDC638JzRok/nxztoist xM5qIHIg5xJ8gafPCYECysF9c5O72UQg791+Ia6RRUDUFTrkGiZa1h9AJPM6KdIHl4XW vHS8xP0Uv5jMAp+aRPOUPTXU/+87x2OsId9+JNU8iL8fx8kHSeFvi4CaHqn65B4kVO5q VPE9fM/E9BexrnBVZxKN//5wTRW7Pn+jf011IW7u7jwImh0TWhltt32SHS4yxoI864o+ aFGvSY1elpzg9yT78bjB9JGNPYZP5oGwnPoj2FzfbB0q+yhfLVsMywX+vtBAUS3FCTU5 7NDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:sender:dkim-signature; bh=WuTDhOoKSUF6ASCrvTob0h6LWV+8ENwHyegd1+7REnw=; b=SZjZD/wXjyOE+i4ErImlpSUndrfNMIRnt34eQBawtP0cBhOeVo8bCS45r5AvGYH7fA o05MeeZbCsjXKaH0/Exq9tSZ0OuAOLdCvJaXFTgVpatwM/bKcIJn3/a3xJcGDd6DRKj6 WSbZ8CEILvMKFudPrLfueIjnq1M2rwoQsZyTTLdfswrWac/B211VOsyO+tWQ8Y6XVeMd DpMWACeqhuEK75v76uuWEpzgYcEG302iTzQw66J+wfMCaxmzu9OunFW3SxVcLeg4SEef CDRaOuHUGvP5bdBEKO3BF7NT2EiwjTq+GmI7iP4SwTDapjVj3r8k7byEHMTpmrxnDBw5 5yYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=JBPDC8zG; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z14-20020a630a4e000000b00439753f7df9si11085745pgk.667.2022.10.09.18.32.24; Sun, 09 Oct 2022 18:32:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=JBPDC8zG; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230100AbiJJBLT (ORCPT + 61 others); Sun, 9 Oct 2022 21:11:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230097AbiJJBLS (ORCPT ); Sun, 9 Oct 2022 21:11:18 -0400 Received: from mail-oo1-xc32.google.com (mail-oo1-xc32.google.com [IPv6:2607:f8b0:4864:20::c32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9EAEC19C24 for ; Sun, 9 Oct 2022 18:11:16 -0700 (PDT) Received: by mail-oo1-xc32.google.com with SMTP id c17-20020a4aa4d1000000b0047653e7c5f3so7104125oom.1 for ; Sun, 09 Oct 2022 18:11:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=WuTDhOoKSUF6ASCrvTob0h6LWV+8ENwHyegd1+7REnw=; b=JBPDC8zGSPGQSvvh7iJmR6H5lGv/Gofioub8+gpkQWb6drS4e1fiirMWDbENGaHPEQ YHfS/RYR/yyF5MuWvsDXBd4cNSDDuHdL9xmWP9+kpu3NJFcthyJ7g5tAs36XhXWD5Ime caJUHLAYRGQ5/eGlEjJKn5zTkMBRijiBrm7qT/PYEQI+v9BKjmi8rlCph4dXtnue4G9X Orw8Jf4IBCdDLE20c3WonkT0J3Nb3Pu6tvRMn/2KcVpySghh2N+FNV9dQ6tdBY2IgUtv pzerk8F5BDcLPPd0H+6pFemhQwm+ulzTb6P3vJ1h7RRZen88RGYrmJLqkWr/ajGvfB+Q C4Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WuTDhOoKSUF6ASCrvTob0h6LWV+8ENwHyegd1+7REnw=; b=7UpWqMieNyBpLzvcsR5SF9DsK5O0BtM3fWUnrkWWi4Hw3KT56dvPXgzWLSUtqc90j2 tllLwSv7jA4UAilsu9NxegKjO7p5XzTVhiJBhzJRld/eoweDwWd13hKD7H7LEGfTlNdr WNjs/pIQVl1H+wx6rIOPJ2NNQLtqKSDZBLs6DKWTP74S4NgQJhAvb9cKLf27/uN3ePYb vqPxLs3Re7BnTCTj0bwR2OcLdXxFaANsi2SsOfzJluIyyqr6NNiBihTDHKRmz88keSw4 lLqcJTnS1YA3uTtOsuqBSR8B9omg4HI0MhZqnL8JmUrBridhpRXc/DweSuSkkSJpQ3UV wrxA== X-Gm-Message-State: ACrzQf1VuOODix+wzzmXUJxVu6PtjOXOVgS9+VcYj2b0QPmJ/ZxdhREB v2KRNYp/borb7pA//yPZwRBy4ym5t6U= X-Received: by 2002:a05:6830:448c:b0:659:d97c:cfab with SMTP id r12-20020a056830448c00b00659d97ccfabmr6868282otv.256.1665364275930; Sun, 09 Oct 2022 18:11:15 -0700 (PDT) Received: from [192.168.1.119] ([216.130.59.33]) by smtp.gmail.com with ESMTPSA id h4-20020a9d7984000000b00661948e6119sm1418278otm.47.2022.10.09.18.11.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 09 Oct 2022 18:11:15 -0700 (PDT) Sender: Larry Finger Message-ID: Date: Sun, 9 Oct 2022 20:11:14 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: rtl8187 triggers usb device reset on kernel driver disconnect To: David Tomaschik , linux-wireless@vger.kernel.org, herton@canonical.com, htl10@users.sourceforge.net References: Content-Language: en-US From: Larry Finger In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 10/7/22 23:33, David Tomaschik wrote: > Hi all, > > It seems that any time the rtl8187 driver is detached from an rtl8187 > interface, a USB device reset is triggered. This is not a problem in > the general case, but when working with libusb, calling > libusb_detach_kernel_driver > (https://libusb.sourceforge.io/api-1.0/group__libusb__dev.html#ga5e0cc1d666097e915748593effdc634a) > results in the device reset, which then causes the kernel driver to > re-attach to the device. This prevents, for example, forwarding the > device into a VM using QEMU/KVM. This seems to be due to > rtl8187_disconnect calling usb_reset_device. > > The 8187 driver seems to be the only realtek driver unconditionally > resetting on disconnect -- is this technically necessary? I'm not > sure I would call this a bug, but it's definitely behavior that was > very puzzling to me and I only understood after enough debugging to > start reading kernel source. David, This behavior certainly is a bug. If one tries to attach the RTL8187 to a VM, it crashes. I will be looking into this issue. Larry