Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp460888rwi; Mon, 10 Oct 2022 02:59:42 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7/eIrldaFrymBKvQOox6ZCDd8+B8bVtasH+a0q/Pz2OLfXW3xipgo0sAkQB6QEtY12C5Mr X-Received: by 2002:a17:90a:7a85:b0:20d:2891:15f with SMTP id q5-20020a17090a7a8500b0020d2891015fmr9314385pjf.107.1665395982482; Mon, 10 Oct 2022 02:59:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665395982; cv=none; d=google.com; s=arc-20160816; b=k5AhA1r15K2iEi/PKiC5jOvRDU/xDF3yEG36rhYSX48/zFdcOxIooNwtWmMOF3b3v4 Rr+bHNCP5rg0ZtSKkFJ1F2ytgCMfScSYsduEhNTLePaPO0nwaI6lj1GwnftFyZVDHnls KnttE9iryWoMnWzSvuZ5A1+JsAB9/aWuxx0cKp+O4g8LyF12WtFzr//k53TqbgqKf4cf D+P2MWAPos4pJijZWryhltyGlMLasVgO84GHbK20huRuQZsgR2WGYdNd1feLaBqxbthH 5MxojeHFb3tEoeZ4IMO2MP9fYvFV6NzvBJQaQtZF54PKu/xxw8LFm1vRbmS6RaiMDcxn Febw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=FFJMIAmvUOe3JtHUldQs90SjA7BN1J1PHfava9TLUiA=; b=XQWYCN/rVjfTUMyQiDppOggcCt48wTQnoKhdsTwPg2SyvOYyV1oe5nJ26U9bYkhqhS n6IxSI5BGJw5L+82aeChKweswX9/fIRZ/AlxJ+uWKIlFaA9BI8xhWYhb5Eu10nzY82Qp yG62ZXGEYxYACCmRYr04reEH12LcInhi6cuHTUTMv/C/BD7OLMzWpqps5eskwiMWIF2c wP/eN1jATaw+OAFWt49Wj38W+8EpzPoCMMxOvbbaUzaDTXSHU6kf7XvSbjfDzbVe+7aw 6KuOTpZ9mx/zrSkTvWks6nPC5/CaoK8siImLiD/LRExzkK3CwrBMKGp8/ef+pZSAWkMn v4+A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=WrIMXj8n; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s4-20020a63f044000000b0042f6352ba2csi11236241pgj.745.2022.10.10.02.59.33; Mon, 10 Oct 2022 02:59:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=WrIMXj8n; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230252AbiJJJxM (ORCPT + 61 others); Mon, 10 Oct 2022 05:53:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48262 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230246AbiJJJxL (ORCPT ); Mon, 10 Oct 2022 05:53:11 -0400 Received: from mail-qk1-x72e.google.com (mail-qk1-x72e.google.com [IPv6:2607:f8b0:4864:20::72e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4E8217586 for ; Mon, 10 Oct 2022 02:53:10 -0700 (PDT) Received: by mail-qk1-x72e.google.com with SMTP id y1so6343277qky.12 for ; Mon, 10 Oct 2022 02:53:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=FFJMIAmvUOe3JtHUldQs90SjA7BN1J1PHfava9TLUiA=; b=WrIMXj8nXIdKcJvI8ZEDA9pQ3j1wtVB4HEEIz6n1YzsnWPB5ClwGoixxZg/kOHoA45 xBO71A2amw3gvKo0WWKXYH2BGDwVITvFYaofG3Ht4Ak8AFTsRgZnsqXXSgppzbD1ajUk BLGEzWNZJQCj7szQ5BNcRjSBzMnKZQE2QVFM0iLve6lL56Uy9n8Im7jkWQqSjS5x3K29 S3A5oIZCs8sriwIAyZMmzgyoAaSl0dYdr7QFOJvIudCtDlfzU3fcTr2m08+MOlCut9aw 8c/CYfGKNKHfJ64qN9hTJ31tAiRXEl9LGPBxCHZIi4xCeB1zGXqQlhgdHpKd1ERElLTC REDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FFJMIAmvUOe3JtHUldQs90SjA7BN1J1PHfava9TLUiA=; b=zXMHLNWqVZMexdsl9Xf5qF7wGY0OlHv2wuK4siXudGD7kNWdCiGScqqN0vhDlWWBvt gm9kCtkD9L1kDzURGhqG/aqvGV+lf3Ul3H129qfMsmyyn+WiC8a80Yse+/by01nDyDln BNMKkqJQqAM+6kC5Ia/jEgtChSUQaHrMViSd1PNbATyEFaRQz/g1qOlV60wrNU/rEE6g x3A/ev+fGTw4nduByqv0YBL44lunbXHoec9JmwjJp7rs5pUQmRCgdtGw1pnowpp/T6Dd XNIWAwr0IA+K2Zd4FfJyagB9oRx15dXg7i7Mq29DbULprD8H0wfDbbYaOZxL+caIG+09 dQVQ== X-Gm-Message-State: ACrzQf3a3Q96iv3AXwidHNOJ8NmcmDrHcJ6BZ1gkwgpjfSScKnfanPbm Qhq0OYpfv+177qvzmC1+gXI= X-Received: by 2002:a05:620a:1727:b0:6ce:9b88:92aa with SMTP id az39-20020a05620a172700b006ce9b8892aamr12037591qkb.160.1665395589814; Mon, 10 Oct 2022 02:53:09 -0700 (PDT) Received: from [10.176.68.61] ([192.19.148.250]) by smtp.gmail.com with ESMTPSA id q24-20020a37f718000000b006ed519554cfsm1590951qkj.61.2022.10.10.02.53.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Oct 2022 02:53:09 -0700 (PDT) Message-ID: <243c9212-0bd0-fa08-056e-efbf6fbcb842@gmail.com> Date: Mon, 10 Oct 2022 11:53:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.1 Subject: Re: [PATCH 1/3] brcmfmac: add a timer to read console periodically in PCIE bus Content-Language: en-US To: Ian Lin , linux-wireless@vger.kernel.org Cc: brcm80211-dev-list@broadcom.com, brcm80211-dev-list@cypress.com, franky.lin@broadcom.com, hante.meuleman@broadcom.com, kvalo@kernel.org, Double.Lo@infineon.com References: <20220929031001.9962-1-ian.lin@infineon.com> <20220929031001.9962-2-ian.lin@infineon.com> From: Arend Van Spriel In-Reply-To: <20220929031001.9962-2-ian.lin@infineon.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 9/29/2022 5:09 AM, Ian Lin wrote: > From: Wright Feng > > Currently, host only reads console buffer when receiving mailbox data or > hit crash with PCIE bus. Therefore, we add timer in PCIE code to read > console buffer periodically to help developer and user check firmware > message when there is no data transmission between host and dongle. These patches are already applied, but wanted to respond still. I know the proprietary driver does use a timer, but it was a design decision to drop that. It adds overhead and complexity which is not resulting in more information about the firmware. Maybe I am missing the exact scenarios in which this would be useful. Also description above says it would help the user, but I very much doubt that. Not much users are fiddling with debugfs and if they are we can call them developers ;-) Regards, Arend