Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <449400ea-9751-e78b-fd90-0389aee39dbd@gmail.com>
Date:   Mon, 10 Oct 2022 12:16:06 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.1
Subject: Re: [PATCH v3 4/4] brcmfmac: Fix authentication latency caused by
 OBSS stats survey
Content-Language: en-US
To:     Ian Lin <ian.lin@infineon.com>, linux-wireless@vger.kernel.org
Cc:     brcm80211-dev-list@broadcom.com, brcm80211-dev-list@cypress.com,
        franky.lin@broadcom.com, hante.meuleman@broadcom.com,
        kvalo@kernel.org, Double.Lo@infineon.com
References: <20220929012527.4152-1-ian.lin@infineon.com>
 <20220929012527.4152-5-ian.lin@infineon.com>
From:   Arend Van Spriel <aspriel@gmail.com>
In-Reply-To: <20220929012527.4152-5-ian.lin@infineon.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/29/2022 3:25 AM, Ian Lin wrote:
> From: Ramesh Rangavittal <ramesh.rangavittal@infineon.com>
> 
> Auto Channel Select feature of HostAP uses dump_survey to fetch
> OBSS statistics. When the device is in the middle of an authentication
> sequence or just at the end of authentication completion, running
> dump_survey would trigger a channel change. The channel change in-turn
> can cause packet loss, resulting in authentication delay. With this change,
> dump_survey won't be run when authentication or association is in progress,
> hence resolving the issue.

It does a bit more than that. It only allows survey when not connected. 
The description above suggests that it is possible when connection is 
completed, but the condition checked below is saying something else.

Regards,
Arend

> Signed-off-by: Ramesh Rangavittal <ramesh.rangavittal@infineon.com>
> Signed-off-by: Chung-Hsien Hsu <chung-hsien.hsu@infineon.com>
> Signed-off-by: Chi-hsien Lin <chi-hsien.lin@infineon.com>
> Signed-off-by: Ian Lin <ian.lin@infineon.com>
> ---
>   drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> index c13c4c559e6e..362d8fd0af4e 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> @@ -7697,6 +7697,12 @@ brcmf_cfg80211_dump_survey(struct wiphy *wiphy, struct net_device *ndev,
>   
>   	brcmf_dbg(TRACE, "Enter: channel idx=%d\n", idx);
>   
> +	/* Do not run survey when VIF in CONNECTING / CONNECTED states */
> +	if ((test_bit(BRCMF_VIF_STATUS_CONNECTING, &ifp->vif->sme_state)) ||
> +	    (test_bit(BRCMF_VIF_STATUS_CONNECTED, &ifp->vif->sme_state))) {
> +		return -EBUSY;
> +	}
> +
>   	band = wiphy->bands[NL80211_BAND_2GHZ];
>   	if (band && idx >= band->n_channels) {
>   		idx -= band->n_channels;