Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <14e43fcd-cb25-abe6-feb5-b41327a1e6df@gmail.com>
Date:   Mon, 10 Oct 2022 13:18:22 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.1
Subject: Re: [PATCH v3 4/5] brcmfmac: Update SSID of hidden AP while informing
 its bss to cfg80211 layer
Content-Language: en-US
To:     Johannes Berg <johannes@sipsolutions.net>,
        "Lin Ian (CSSITB CSS ICW SW WFS / EE)" <ian.lin@infineon.com>,
        Kalle Valo <kvalo@kernel.org>
Cc:     linux-wireless@vger.kernel.org, brcm80211-dev-list@broadcom.com,
        franky.lin@broadcom.com, hante.meuleman@broadcom.com,
        Double.Lo@infineon.com
References: <20220927034138.20463-1-ian.lin@infineon.com>
 <20220927034138.20463-5-ian.lin@infineon.com> <874jwsrojr.fsf@kernel.org>
 <4e602611-aed5-dfe7-6ce7-42d1fc7ca53e@infineon.com>
 <b43d934d-f3e8-9459-0096-11908df27c15@infineon.com>
 <87y1tupuqy.fsf@kernel.org> <9e166687-1d35-4216-5c2c-a0e783ead406@gmail.com>
 <51236a0c-5210-533b-7755-94145e6c5a1d@infineon.com>
 <b7518fd9-fcd1-0ddb-e1cc-2bc7687d3ab7@gmail.com>
 <065a6cc23f5553fd6d7d98b1e9c533d3f4e544a6.camel@sipsolutions.net>
From:   Arend Van Spriel <aspriel@gmail.com>
In-Reply-To: <065a6cc23f5553fd6d7d98b1e9c533d3f4e544a6.camel@sipsolutions.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/10/2022 11:41 AM, Johannes Berg wrote:
> On Mon, 2022-10-10 at 11:23 +0200, Arend Van Spriel wrote:
>>   Maybe I am mistaken and the SSID element for the
>> Hidden-SSID scenarion is different. Will check the 802.11 spec.
>>
> 
> hidden SSID isn't in the spec, but these days is typically implemented
> by a zero-size SSID element:
> 
>   00 00
> 
> In the past, sometimes it would also be done by some APs with a zeroed
> SSID element, e.g. for the SSID "myAP" you could see
> 
>   00 04 00 00 00 00
> 
> instead.

Thanks, Johannes

If both species are out there than it still means blindly copying things 
into the TLV buffer is not the proper thing to do here.

Regards,
Arend

> johannes