Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp839744rwi; Mon, 10 Oct 2022 07:53:21 -0700 (PDT) X-Google-Smtp-Source: AMsMyM51hSLsYuHHgFgUL1SLepxHu460TJEOdBNvL0d/8GSG+DXLreA5+bPYl/ddHbHlk0Srtjg1 X-Received: by 2002:a17:907:d90:b0:78d:48b1:496d with SMTP id go16-20020a1709070d9000b0078d48b1496dmr15211057ejc.665.1665413601557; Mon, 10 Oct 2022 07:53:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665413601; cv=none; d=google.com; s=arc-20160816; b=EXA7otPyqNYHUJIgALcOToc3o5nP+86ErZxjZcSTilXdFHdQ7RCFKcl6bHAnZM8zEB dfwKCZKDUElw+Ca9sq6HO86+f3z+kRdvoBS8N/3X1RePgySDCqGDncXMjUwx1HXtJC6r TXjcvZZFtuxvw45RI9QLpV35B/TbKlDx6qrRLtl/Lgfn20+CDZ8VorzVk6lvnUNp+7z2 kp7rYi+RlYFes5vmVKjR/uowG5yNX/bk0iV6K36Vk43Qiv3rWVqzWyvh18ykNZL2G6Hn oYDBjpA9KB3f+QGnPC8MhdEnFQ0hO85cxqDnJIw4zRyMD4K5BArjewU/pYznIZZKOVly b63Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:references:in-reply-to:subject:cc:to:dkim-signature :from; bh=ZmV5YKC2d7GUyWQSoT7ZLwOBBLhNuu6XaB/nkGcRIKc=; b=mcFvEYqqLZD9JJlLoAUL/Z9OndH2aavk0n7WoImCX1M3lPfc7B2vgs0heUDm9FkXC4 RfdQm99UzatAGWrpUk4/x1N3cxqow9vvn+EmRwv9RMQU0IEtfSkjWhNFLo9qsQUTOBf/ tKpUtUMaCjVXVhnmwLQ0WwdS9MjfhvwkD9hiEGLsJ3qoAwvAU/MF73qfgSM6tA9NyK8m gtKSq11yZPGnXC8IRqtdamTEHo13G7ua/3u1O2t59oTHeWmqfj/9e1bw0L92smuyOH8p ykd7tRoZFyoswBP2zmQHkAZlS2XzolYuwXYJ5PrZ2D4AuwZLcqZ5qX7oZOhZr/PLR0MJ +0mA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@toke.dk header.s=20161023 header.b=P2UhtnoK; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=toke.dk Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i21-20020a170906251500b0073305fd2278si7412940ejb.864.2022.10.10.07.52.58; Mon, 10 Oct 2022 07:53:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@toke.dk header.s=20161023 header.b=P2UhtnoK; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=toke.dk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229917AbiJJOon (ORCPT + 61 others); Mon, 10 Oct 2022 10:44:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229913AbiJJOol (ORCPT ); Mon, 10 Oct 2022 10:44:41 -0400 Received: from mail.toke.dk (mail.toke.dk [45.145.95.4]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C935A1035 for ; Mon, 10 Oct 2022 07:44:38 -0700 (PDT) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1665413076; bh=IxAltLphTucQjT8kmi7p/8lfTX2Y9yxUTefelUXm8jI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=P2UhtnoK8IlMyGPIhlwvylzljjZTWHG0xx7XttoOk0L1CyYUBZgzaE53zXROVjHXd OuLWpgkHN1tS0zXzUEQ6zZXtYmIQS12uYpKT8leWsXFS5tpeQP7HHTqnj4nsSlItLO Hp+559QS/LRpwmFHgMuhWA9pncWFcxhnTjEEeIyYvAQtwj4EuDLz6jNJHzJCP2iZRH xighLecEU1BF/R76naGqtYHD/gUi0w5DxyzzC1X7beWLsW80E6KH52FDdq8dEdrpvk +9FnPs3DlV1vCcGtzu3pETC0uMJlOJ2flNtbu+7lOTkmoPJBhJOAlgCfDAsuo55ocu wd6nwozhW0P0w== To: Alexander Wetzel , linux-wireless@vger.kernel.org Cc: johannes@sipsolutions.net, Alexander Wetzel Subject: Re: [PATCH v2 1/3] wifi: mac80211: add internal handler for wake_tx_queue In-Reply-To: <20221009163040.25637-1-alexander@wetzel-home.de> References: <20221009163040.25637-1-alexander@wetzel-home.de> Date: Mon, 10 Oct 2022 16:44:36 +0200 X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <87y1tnrb57.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Alexander Wetzel writes: > Start to align the TX handling to only use internal TX queues (iTXQs): > > Provide a handler for drivers not having a custom wake_tx_queue > callback and update the documentation. > > Signed-off-by: Alexander Wetzel > --- > > This is the v2 for "wifi: mac80211: Use internal TX queues for all driver= s" > https://patchwork.kernel.org/project/linux-wireless/patch/20220926161303.= 13035-1-alexander@wetzel-home.de/ > > Changes compared to V1: > - broken out the new wake_tx_queue handler as exported function > - update drivers to provide wake_tx_queue instead handling it internally > - Minor docu updates > - Some sentences of the edited docu were referring to wrong netif > functions. Fixed that with the edit, too. > - added a comment explaining why we call ieee80211_next_txq() > - removed now pointless checks for sta.txq I think this version looks quite reasonable. For the series: Acked-by: Toke H=C3=B8iland-J=C3=B8rgensen