Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To:     alexander@wetzel-home.de
Cc:     johannes@sipsolutions.net, linux-wireless@vger.kernel.org
Subject: RE: [PATCH v2 2/3] wifi: mac80211: add wake_tx_queue callback to drivers
Date:   Mon, 10 Oct 2022 18:16:21 +0200
Message-Id: <20221010161621.1855515-1-martin.blumenstingl@googlemail.com>
In-Reply-To: <20221009163040.25637-2-alexander@wetzel-home.de>
References: <20221009163040.25637-2-alexander@wetzel-home.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

[...]
> diff --git a/drivers/net/wireless/realtek/rtw88/mac80211.c b/drivers/net/wireless/realtek/rtw88/mac80211.c
> index 07578ccc4bab..bf917ef20e3b 100644
> --- a/drivers/net/wireless/realtek/rtw88/mac80211.c
> +++ b/drivers/net/wireless/realtek/rtw88/mac80211.c
> @@ -896,6 +896,7 @@ static void rtw_ops_sta_rc_update(struct ieee80211_hw *hw,
>  
>  const struct ieee80211_ops rtw_ops = {
>  	.tx			= rtw_ops_tx,
> +	.wake_tx_queue		= ieee80211_handle_wake_tx_queue,
>  	.wake_tx_queue		= rtw_ops_wake_tx_queue,
>  	.start			= rtw_ops_start,
>  	.stop			= rtw_ops_stop,
> diff --git a/drivers/net/wireless/realtek/rtw89/mac80211.c b/drivers/net/wireless/realtek/rtw89/mac80211.c
> index a296bfa8188f..91674c63b9f9 100644
> --- a/drivers/net/wireless/realtek/rtw89/mac80211.c
> +++ b/drivers/net/wireless/realtek/rtw89/mac80211.c
> @@ -918,6 +918,7 @@ static int rtw89_ops_set_tid_config(struct ieee80211_hw *hw,
>  
>  const struct ieee80211_ops rtw89_ops = {
>  	.tx			= rtw89_ops_tx,
> +	.wake_tx_queue		= ieee80211_handle_wake_tx_queue,
>  	.wake_tx_queue		= rtw89_ops_wake_tx_queue,
>  	.start			= rtw89_ops_start,
>  	.stop			= rtw89_ops_stop,

For rtw88 and rtw89 the wake_tx_queue callback is now duplicated.
I'm not sure if other drivers are affected as well.


Best regards,
Martin