Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <35c743cf4468bcf5ebbbefd2bf6e3faae9cdd1cf.camel@sipsolutions.net>
Subject: Re: [PATCH v2 2/3] wifi: mac80211: add wake_tx_queue callback to
 drivers
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
        alexander@wetzel-home.de
Cc:     linux-wireless@vger.kernel.org
Date:   Mon, 10 Oct 2022 18:45:21 +0200
In-Reply-To: <20221010161621.1855515-1-martin.blumenstingl@googlemail.com>
References: <20221009163040.25637-2-alexander@wetzel-home.de>
         <20221010161621.1855515-1-martin.blumenstingl@googlemail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Mon, 2022-10-10 at 18:16 +0200, Martin Blumenstingl wrote:
> [...]
> > diff --git a/drivers/net/wireless/realtek/rtw88/mac80211.c b/drivers/ne=
t/wireless/realtek/rtw88/mac80211.c
> > index 07578ccc4bab..bf917ef20e3b 100644
> > --- a/drivers/net/wireless/realtek/rtw88/mac80211.c
> > +++ b/drivers/net/wireless/realtek/rtw88/mac80211.c
> > @@ -896,6 +896,7 @@ static void rtw_ops_sta_rc_update(struct ieee80211_=
hw *hw,
> > =20
> >  const struct ieee80211_ops rtw_ops =3D {
> >  	.tx			=3D rtw_ops_tx,
> > +	.wake_tx_queue		=3D ieee80211_handle_wake_tx_queue,
> >  	.wake_tx_queue		=3D rtw_ops_wake_tx_queue,
> >  	.start			=3D rtw_ops_start,
> >  	.stop			=3D rtw_ops_stop,
> > diff --git a/drivers/net/wireless/realtek/rtw89/mac80211.c b/drivers/ne=
t/wireless/realtek/rtw89/mac80211.c
> > index a296bfa8188f..91674c63b9f9 100644
> > --- a/drivers/net/wireless/realtek/rtw89/mac80211.c
> > +++ b/drivers/net/wireless/realtek/rtw89/mac80211.c
> > @@ -918,6 +918,7 @@ static int rtw89_ops_set_tid_config(struct ieee8021=
1_hw *hw,
> > =20
> >  const struct ieee80211_ops rtw89_ops =3D {
> >  	.tx			=3D rtw89_ops_tx,
> > +	.wake_tx_queue		=3D ieee80211_handle_wake_tx_queue,
> >  	.wake_tx_queue		=3D rtw89_ops_wake_tx_queue,
> >  	.start			=3D rtw89_ops_start,
> >  	.stop			=3D rtw89_ops_stop,
>=20
> For rtw88 and rtw89 the wake_tx_queue callback is now duplicated.
> I'm not sure if other drivers are affected as well.
>=20

Ouch. I looked at a whole bunch of them, how did that not cause a
compiler warning??

I'll check and fix.

johannes