Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220923015550.1292547-1-jaewan@google.com> <1f98f992c4766acbecaeb7066e00b0ca2e2c64fa.camel@sipsolutions.net>
In-Reply-To: <1f98f992c4766acbecaeb7066e00b0ca2e2c64fa.camel@sipsolutions.net>
From:   Jaewan Kim <jaewan@google.com>
Date:   Tue, 11 Oct 2022 14:34:26 +0900
Message-ID: <CABZjns4F2s+77H6kdGt2OCAy-OAQ_BSzJ3S_NxQxuN_pPgn79w@mail.gmail.com>
Subject: Re: [PATCH] iw: info: print PMSR capabilities
To:     Johannes Berg <johannes@sipsolutions.net>
Cc:     linux-wireless@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Oct 5, 2022 at 6:48 PM Johannes Berg <johannes@sipsolutions.net> wr=
ote:
>
> On Fri, 2022-09-23 at 10:55 +0900, Jaewan Kim wrote:
> >
> > +++ b/info.c
> > @@ -741,6 +741,9 @@ broken_combination:
> >                       pat->max_pattern_len, pat->max_pkt_offset, rule->=
max_delay);
> >       }
> >
> > +     if (tb_msg[NL80211_ATTR_PEER_MEASUREMENTS])
> > +             print_pmsr_capabilities(tb_msg[NL80211_ATTR_PEER_MEASUREM=
ENTS]);
> > +
> >       if (tb_msg[NL80211_ATTR_MAX_AP_ASSOC_STA])
> >               printf("\tMaximum associated stations in AP mode: %u\n",
> >                      nla_get_u16(tb_msg[NL80211_ATTR_MAX_AP_ASSOC_STA])=
);
> > diff --git a/iw.h b/iw.h
> > index e712c59..0707cb4 100644
> > --- a/iw.h
> > +++ b/iw.h
> > @@ -221,6 +221,7 @@ void print_vht_info(__u32 capa, const __u8 *mcs);
> >  void print_he_capability(const uint8_t *ie, int len);
> >  void print_he_info(struct nlattr *nl_iftype);
> >  void print_eht_info(struct nlattr *nl_iftype, int band);
> > +void print_pmsr_capabilities(const struct nlattr *pmsr_capa);
>
> Also, FWIW, it would probably make sense to make this static and put it
> into info.c at least while it's not used elsewhere?
>
> johannes

My apologies. I made a mistake when moving changes from the Android repo.
Could you take another look at the patch? It would be a great help.

--=20
Jaewan Kim (=EA=B9=80=EC=9E=AC=EC=99=84) | Software Engineer in Google Kore=
a |
jaewan@google.com | +82-10-2781-5078