Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 11 Oct 2022 09:35:35 +0200
From:   Lorenzo Bianconi <lorenzo@kernel.org>
To:     Ryder Lee <ryder.lee@mediatek.com>
Cc:     Felix Fietkau <nbd@nbd.name>, linux-wireless@vger.kernel.org,
        Lorenzo Bianconi <lorenzo.bianconi@redhat.com>,
        Shayne Chen <shayne.chen@mediatek.com>,
        Evelyn Tsai <evelyn.tsai@mediatek.com>,
        linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] wifi: mt76: mt7915: prevent unexpected nss setting from
 eeprom
Message-ID: <Y0Ucx6+6TjEfPV17@lore-desk>
References: <efa6ba9cd8ad5124f58e05155cc05008b14c5edf.1665453585.git.ryder.lee@mediatek.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="cDg6v/7QPvTVC2k7"
Content-Disposition: inline
In-Reply-To: <efa6ba9cd8ad5124f58e05155cc05008b14c5edf.1665453585.git.ryder.lee@mediatek.com>
Precedence: bulk


--cDg6v/7QPvTVC2k7
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

> Add a check to prevent unexpected nss configuration from eeprom.

I am wondering why we need to add a check for this particular field. Is it a
well-known problem?

Regards,
Lorenzo

>=20
> Fixes: 4d8053df67c5 ("wifi: mt76: mt7915: rework eeprom tx paths and stre=
ams init")
> Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
> ---
>  drivers/net/wireless/mediatek/mt76/mt7915/eeprom.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/eeprom.c b/drivers=
/net/wireless/mediatek/mt76/mt7915/eeprom.c
> index e2482c65d639..6c5155223087 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7915/eeprom.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7915/eeprom.c
> @@ -191,7 +191,6 @@ void mt7915_eeprom_parse_hw_cap(struct mt7915_dev *de=
v,
>  		path =3D 4;
> =20
>  	/* read tx/rx stream */
> -	nss =3D path;
>  	if (dev->dbdc_support) {
>  		if (is_mt7915(&dev->mt76)) {
>  			nss =3D FIELD_GET(MT_EE_WIFI_CONF3_TX_PATH_B0,
> @@ -206,6 +205,11 @@ void mt7915_eeprom_parse_hw_cap(struct mt7915_dev *d=
ev,
> =20
>  		if (!is_mt7986(&dev->mt76))
>  			nss_max =3D 2;
> +
> +		if (!nss)
> +			nss =3D nss_max;
> +	} else {
> +		nss =3D path;
>  	}
> =20
>  	nss =3D min_t(u8, min_t(u8, nss_max, nss), path);
> --=20
> 2.36.1
>=20

--cDg6v/7QPvTVC2k7
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCY0UcxgAKCRA6cBh0uS2t
rOPdAQCKrWYAct/uSUQzcbTdRqLtPFS6mew43S2Gq0GX5hn+bwEA1rgunDydicfs
G582C7THc97apLzQ8h7NeUOJoNUheQE=
=23rp
-----END PGP SIGNATURE-----

--cDg6v/7QPvTVC2k7--