Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp1906870rwi; Tue, 11 Oct 2022 02:00:07 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4hFMb4cxqSR5HUBURwenTi/PvnPRHUtWgSb/OMYjjq7+/Erw4s3scPeRI+mzSWjnnlELGK X-Received: by 2002:a05:6a00:f03:b0:563:210a:5ffb with SMTP id cr3-20020a056a000f0300b00563210a5ffbmr13908114pfb.70.1665478807033; Tue, 11 Oct 2022 02:00:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665478807; cv=none; d=google.com; s=arc-20160816; b=ZVCfk5AvdUTLkmfA73u4K5P/2feO6cgToUalSWu/ZL7CNpGW3g0Lc6XI+/xAXqwdC6 HwFCt7n+S1Vhere1rjQLDuRLhLrmqe91qcjteQpfyc7zVDdzGNmLR6Z65XBeVvKJLHl4 4mMl5wh5wmE1swGvmERprZV8IDpNlvt7Nt0GT+IR1OWdwEDPk3FjLNS9htKnvOUWyAPi cSWmgcch6fcfiKBJLBXBE9tQfykJ9giCUF1Zys+3C28pR9t3hX0443e22mpbJFb6jW4p qm/kf1ugVl1rLlLbv3eOi2etdcyaCZuWOUazumnwa/auQiqOmqoT6odvAVHFZJ9MKIgz cHhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=8TEKWDB2OUHKnmCquTsu1ytXdxE4eMVdpwFXjJx7DUU=; b=0qT9fnmTCkfaxap4FyI3ljqlQGyJGkkQAo2jbG7LmgXjsf5Bq+D1kRK6GDZjtHx0X3 RYCWLPw3hb4j++9NqQgJSqbUWYN7sEDFnn3jaGPQgCfgvXay1eFTBK1YLrF3Wc7ZTLIG loXOgH2Mj28GD2TEjALez9pXLkDvNn4KWGVo3vRb4VmBVnymMamuYnB1301qPac8XU0p hqvwM7MPhII6YTDNvyJQbWpYR/x3q320cPoMe/vC4w7TAy4qTYDRJWj7jDl9zzWvHzLM f45UDy36c4fSaycy5LBKqi20IEzlfjV/jq0zyers2vQs3N9NA2KO9uib4DySm0wT7Bks EoVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mwgZlUBV; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 15-20020a17090a08cf00b00209febadb7esi18258627pjn.24.2022.10.11.01.59.56; Tue, 11 Oct 2022 02:00:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mwgZlUBV; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229868AbiJKImH (ORCPT + 61 others); Tue, 11 Oct 2022 04:42:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229810AbiJKImF (ORCPT ); Tue, 11 Oct 2022 04:42:05 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 613E174CFB for ; Tue, 11 Oct 2022 01:42:04 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CB19E6114D for ; Tue, 11 Oct 2022 08:42:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 74678C433C1; Tue, 11 Oct 2022 08:42:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665477723; bh=OMYmx/26nbOXubts18uFutcbJVA+GFfR3LxpIn/FKTk=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=mwgZlUBVLiZsbDVfFEtbwusG/BWOqS0fFeE8PJj2d+q4dVchPgi+zfO8Kka0MDNd8 Wq5/pz1M2biD8FBHW+uA1RpMqpGHJn6wz8AnGaAGDL1XpgMA+GLX2iBEG87Y4/VUoM u05PFazy6uY8b189wyyiqQCyWzRvejvTwWFpH32889FlWWJqtti5OCrOoYsC4xH6WO Fb6XPupQX1mo0VBjY+53o0Xm1qHCKkUBr8UEELCUINAVjDkT44o+Ix8NUuDvw33+R3 PaMJ8cWh80Gg34RQx6GhEriOwBxAQaySrxWfCr+R34ow0MQGyBChjRqqd40m1EhIH1 avxGCcf+kwjnQ== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH 6.1 1/2] wifi: mt76: fix receiving LLC packets on mt7615/mt7915 From: Kalle Valo In-Reply-To: <20221005130824.23371-1-nbd@nbd.name> References: <20221005130824.23371-1-nbd@nbd.name> To: Felix Fietkau Cc: linux-wireless@vger.kernel.org, Chad Monroe User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <166547771808.14345.12170744535376568553.kvalo@kernel.org> Date: Tue, 11 Oct 2022 08:42:02 +0000 (UTC) X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Felix Fietkau wrote: > When 802.3 decap offload is enabled, the hardware indicates header translation > failure, whenever either the LLC-SNAP header was not found, or a VLAN header > with an unregcognized tag is present. > In that case, the hardware inserts a 2-byte length fields after the MAC > addresses. For VLAN packets, this tag needs to be removed. However, > for 802.3 LLC packets, the length bytes should be preserved, since there > is no separate ethertype field in the data. > This fixes an issue where the length field was omitted for LLC frames, causing > them to be malformed after hardware decap. > > Fixes: 1eeff0b4c1a6 ("mt76: mt7915: fix decap offload corner case with 4-addr VLAN frames") > Reported-by: Chad Monroe > Signed-off-by: Felix Fietkau 2 patches applied to wireless.git, thanks. 47c44088ac08 wifi: mt76: fix receiving LLC packets on mt7615/mt7915 443dc85ad13e wifi: mt76: fix rx checksum offload on mt7615/mt7915/mt7921 -- https://patchwork.kernel.org/project/linux-wireless/patch/20221005130824.23371-1-nbd@nbd.name/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches