Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <11ea25ad-0ad9-7d34-de3f-09ca7d9c4ee2@gmail.com>
Date:   Wed, 12 Oct 2022 14:10:33 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.1
Content-Language: en-US
To:     Larry Finger <Larry.Finger@lwfinger.net>
Cc:     Kalle Valo <kvalo@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Paolo Abeni <pabeni@redhat.com>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
From:   "Colin King (gmail)" <colin.i.king@gmail.com>
Subject: rtlwifi: missing return value in
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

Static analysis with cppcheck has found an issue with a function that 
returns an int value but there is a code path that does not return a 
value causing undefined behaviour:

Source: drivers/net/wireless/realtek/rtlwifi/usb.c function 
_rtl_rx_get_padding - introduced by commit:

commit 354d0f3c40fb40193213e40f3177ff528798ca8d
Author: Larry Finger <Larry.Finger@lwfinger.net>
Date:   Wed Sep 25 12:57:47 2013 -0500

     rtlwifi: Fix smatch warnings in usb.c

The issue occurs when NET_IP_ALIGN is zero and when len >= sizeof(*hdr), 
then the following return is *not* taken:

	/* make function no-op when possible */
         if (NET_IP_ALIGN == 0 || len < sizeof(*hdr))
                 return 0

and then execution reaches the end of the function where no return value 
is returned because the #if NET_IP_ALIGN != 0 is false so the return 
padding hunk of the code is not compiled in.

Colin