Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
From:   Don Bowman <db@donbowman.ca>
Date:   Wed, 12 Oct 2022 16:37:26 -0400
Message-ID: <CADJev7-wMryV+Mw=cHBLAXT0nXVB5fbyYNyqWc5aBhBLUbm7pw@mail.gmail.com>
Subject: re: [PATCH 10/12] iwlwifi: Add support for getting rf id with blank
 otp Inbox
To:     linux-wireless@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

From: Luca Coelho <luca@coelho.fi>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 10/12] iwlwifi: Add support for getting rf id with blank otp
Date: Thu, 26 Aug 2021 14:45:55 +0300 [thread overview]
Message-ID: <e9265c03dee77861f5aeb8d94569b51d28bca148.camel@coelho.fi> (raw)
In-Reply-To: <ce687133d7edf29abb421a9f1a105bb9eedd9761.camel@coelho.fi>

On Thu, 2021-08-26 at 14:30 +0300, Luca Coelho wrote:
> On Sat, 2021-08-21 at 17:07 +0300, Kalle Valo wrote:
> > Luca Coelho <luca@coelho.fi> writes:
> >
> > > From: Matti Gottlieb <matti.gottlieb@intel.com>
> > >
> > > When having a blank OTP the only way to get the rf id
> > > and the cdb info is from prph registers.
> > >
> > > Currently there is some implementation for this, but it
> > > is located in the wrong place in the code (should be before
> > > trying to understand what HW is connected and not after),
> > > and it has a partial implementation.
> > >
> > > Signed-off-by: Matti Gottlieb <matti.gottlieb@intel.com>
> > > Signed-off-by: Luca Coelho <luciano.coelho@intel.com>


I find this patch breaks my Asus UX433FA
Intel Corporation Cannon Point-LP CNVi [Wireless-AC] (rev 30)

[    4.350690] iwlwifi 0000:00:14.3: enabling device (0000 -> 0002)
[    4.352211] iwlwifi 0000:00:14.3: Can find a correct rfid for crf id 0x5a2
[    4.352239] iwlwifi: probe of 0000:00:14.3 failed with error -22

it worked prior. I notice a few other people online with the same
cannon point asus with the same issue.

I'm not sure what other diagnostics i can provide but more than happy
to. Is there a way to dump the OTP out?

00:14.3 Network controller: Intel Corporation Cannon Point-LP CNVi
[Wireless-AC] (rev 30)
DeviceName: WLAN
Subsystem: Intel Corporation Cannon Point-LP CNVi [Wireless-AC]
Flags: fast devsel, IRQ 16
Memory at b111c000 (64-bit, non-prefetchable) [size=16K]
Capabilities: [c8] Power Management version 3
Capabilities: [d0] MSI: Enable- Count=1/1 Maskable- 64bit+
Capabilities: [40] Express Root Complex Integrated Endpoint, MSI 00
Capabilities: [80] MSI-X: Enable- Count=16 Masked-
Capabilities: [100] Null
Capabilities: [14c] Latency Tolerance Reporting
Capabilities: [164] Vendor Specific Information: ID=0010 Rev=0 Len=014 <?>
Kernel modules: iwlwifi