Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Sriram R (QUIC)" <quic_srirrama@quicinc.com>
To:     Ping-Ke Shih <pkshih@realtek.com>, Kalle Valo <kvalo@kernel.org>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
CC:     "ath12k@lists.infradead.org" <ath12k@lists.infradead.org>
Subject: RE: [PATCH 05/50] wifi: ath12k: add core.c
Thread-Topic: [PATCH 05/50] wifi: ath12k: add core.c
Thread-Index: AQHYrmYQb/hfAMcftEyJRue7rvMdCK3dFFqAgC6uvCA=
Date:   Wed, 12 Oct 2022 23:12:09 +0000
Message-ID: <SN6PR02MB4334D9D892AD577316C3CCBDF7229@SN6PR02MB4334.namprd02.prod.outlook.com>
References: <20220812161003.27279-1-kvalo@kernel.org>
 <20220812161003.27279-6-kvalo@kernel.org>
 <6cce0974d5bb40c2a2a40b4abeb41e74@realtek.com>
In-Reply-To: <6cce0974d5bb40c2a2a40b4abeb41e74@realtek.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: SN6PR02MB4334:EE_|MN2PR02MB6781:EE_
x-ms-office365-filtering-correlation-id: 450072be-acf1-4fe2-99f3-08daaca730a5
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 45rf1OSHKVAdBgn2lFQiOXRehjb9PJ1evv1kEcH7aHwj8Nk1zcrqHkqQ26//s7jGTJynAZeIzGNn9+N+xBBa85yv2flbgUu0VhXTAMCAMq9cTY6OnadXTiqH3UD0fiv+peUjjQXPdPkllAPxyh+JMk25brhguvVNkfgIgQIFEJfOADI0Atd1XXlTNGAGbdJU7e03P6ZIP4tbH49FhPYDRsKX5R5TU+mKv3MTyeQpspaONWUweC2Khn0XiHYv/ZXj1BmGyFr0jztK0+yISuvVMthWRGCeei3Hq4teeuqPhcw0aOAFZYkNflwOAToDT+7pbUzFS6l3X+h/D2V2JuRtUm0U6VFngUAcd8GPskChnLtd1C73bFu6um1FLukvxVMhoirn+/lUZ3tNQNAUxDOIceyXXfxhS2zTq94cQ+37IvUhAFF23T9rkIqEVO3lBOmle5DrnX9frDNcGzaypJhcGjSxwv4NCzcx0hvRcpdyyPbLgXV6xry0Uei0JXNhmQPRjasduv+VQ43DSa6NKH9hqIgenHsOh4cMMOZgtNclB6stHhZoSRqNbkrwMKEmCrjfq6P5pDVuszeQBUBUQRMHb/CWDKoda4Cpj7gq48/Rv7gC/3yppEFvKyzF5Z2ZR9gIl7B3rj574Tt6qNAwJoqcUZ3T1FzDcS9F/RVuDXe16KPTHQJHsNxlz7QQ9tOvCQSf+8FbwwKcMwCZ6pPFxQYfF0M2sZJH9NquFVyL33wmgIBczOOo2nOjqd+x4UtldYETGAkvkKh1hS9c2+8FrB47Ww==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR02MB4334.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(366004)(39860400002)(136003)(376002)(451199015)(66446008)(38100700002)(7696005)(8676002)(4326008)(38070700005)(55016003)(41300700001)(86362001)(64756008)(6506007)(33656002)(52536014)(76116006)(8936002)(66946007)(5660300002)(9686003)(110136005)(478600001)(186003)(71200400001)(66556008)(316002)(26005)(122000001)(66476007)(2906002);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?RZF0EwZtUT/y8t66DZJfia3XL4cqMyx9Nvc4pE6gYiCfJ9d9MTXjKohhZlA2?=
 =?us-ascii?Q?pNLNMCh+sMn+gmjutEx6NKs6uOKJKxmLQesSpJOcoH9Y/la/dCbabGXpvVwg?=
 =?us-ascii?Q?QBUqM9nWhlr5mGh/Rdgv4cCVig98iUZMYj0bxxNgWywRzX/14Ci+bX92JGoU?=
 =?us-ascii?Q?QXDSVE9n/LB5pdAWStbYUPBu+h+mcp/abajK+7FkXjrQUlB7asGdp9hClT3k?=
 =?us-ascii?Q?1tj15sV/YnsJWB67+WGZmb3HUTAOwaa7hopA+/2LZhPCc22RQOx5KMnMJObr?=
 =?us-ascii?Q?BDYCEpy85261pzKnDDoCWW1AurwrQN50r3JuAI91RFfBAMlnH1k5+HDxE34I?=
 =?us-ascii?Q?a7k0e7gSk+9AJBtKhnRi0eRvZcuIB+IQcD8MW8tTRjvvsqE/SohOkYRlxEAH?=
 =?us-ascii?Q?1TKBZ8CxPhrVGEcV5gJ0IfR46HWLT2+ulMqkTkEaebn8ebR0BmFuh33c8rTk?=
 =?us-ascii?Q?Cx9QuVdBVgF8hot8QfLpK2ECYlADlpUvCQ1L9os6DOns5h0V+QqYvD/AGGRG?=
 =?us-ascii?Q?Mn/tMp/3v67Mt1srZJ2ykkIZ5cXC60/Bsmo60KtFp7jSCr0AHXY7t7EglXCD?=
 =?us-ascii?Q?3JqqefgNqiY2x5YzFSQOY0LLl1SGF/bRLnd15+FiIqvs8QNG4Wl6WjA/+5bo?=
 =?us-ascii?Q?N8OxdHu5FCl6xUsG8pnykKOE83bYKmDJp7OB+GQ/6XrWgeLhMprZYkzPC7qD?=
 =?us-ascii?Q?B9s6xChtckmdxcUtiW+xUHTahRG14Q+2IJr0avof/mCIgpeS//GGUMlHeQFz?=
 =?us-ascii?Q?LPnny19bL4tlt6rgPn/VO+cxwIEAF8pMlL2skraREzgr3NNzm4qvX0Vz536a?=
 =?us-ascii?Q?MydOWXGy4LmQsb9lqHSpXBzNlkoLfeSnBrgdGrTyfiUoLFGfzIF6ph/UQtqq?=
 =?us-ascii?Q?0hoKgbiAPjHCKVTmyt5t3nIln1ogPXVJ37OzEy7GAJd+eZsUpPL9ImArPPPS?=
 =?us-ascii?Q?eZq/rY4Nb1lkobUSJTSlr+325mlpBL44IHoBqdNPShaX+dUtTRXMK2s5LrRg?=
 =?us-ascii?Q?h3JBHY49y7z8oeGxU9yAOyiyMFhG140AICLt1dp0GSUr+LzshtbHbuDtsgLE?=
 =?us-ascii?Q?JYnupkbJHz4K3Xyc+2BzLx7gb+CPgR1As9JIniAyDMXvDxq28MZdR5V+HQUU?=
 =?us-ascii?Q?+ahuZR0GpbWMDw6AqYkAUO7gPVP2/DLmZ6cFFgekcDHoJIHOuy0bYVZd1NE+?=
 =?us-ascii?Q?OFPa1hDo5/gbzfRoGltzAPe/TeLcoewX50w64wlPEz0hZl2yaCkqWXARbfPK?=
 =?us-ascii?Q?4J1rOL7GwXRH4evrVajNYnlSpG+hhv9OREE+NeiEfs1UxDt/ALdtZm8ZNmHu?=
 =?us-ascii?Q?T4IpUefyKDSEfQ7DhOacx9zExGvdnwe9HeQE3R06W4jnq2e48weVcarY+l+E?=
 =?us-ascii?Q?rmv+5+H/Xo6aaprogUV1cqgOkuvulyDwjTvZAKEZfJDoyr5e/by1ymoLQPMN?=
 =?us-ascii?Q?dvtzhOvA3BMqkbuJz5AxsHwbPKXwWEmcXjEWFhCN5Iu4qsQXPXf+8NDe0+Ds?=
 =?us-ascii?Q?4Bwtf0a5E8QKr3lOBY7x/EqOJ5BwVXKC+u5rWz8AOLSZIkIBc1NV6FqT+P0V?=
 =?us-ascii?Q?gf3il+SC3m8DkXVJg74z2DdR9rwm5X2t707Ki5cW?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: quicinc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR02MB4334.namprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 450072be-acf1-4fe2-99f3-08daaca730a5
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2022 23:12:10.1709
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 98e9ba89-e1a1-4e38-9007-8bdabc25de1d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: s0/+eIlNC37k+J1Vq8ThERuDm1Rr3ZNsw0BGqzCeOx4fZhu8ZVLIDnU6FoPjqhpDt52QSomK6J6LAd6BrlyT71U5Jm57sDuukzf8isOLb3Q=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR02MB6781
X-Proofpoint-GUID: Mg-VUtQxfQbC3eG5kifSmBDymPmSkHkg
X-Proofpoint-ORIG-GUID: Mg-VUtQxfQbC3eG5kifSmBDymPmSkHkg
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-12_11,2022-10-12_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 mlxscore=0
 impostorscore=0 bulkscore=0 phishscore=0 spamscore=0 suspectscore=0
 lowpriorityscore=0 mlxlogscore=996 adultscore=0 malwarescore=0
 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2210120145
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,
        SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

>> +static int ath12k_core_start(struct ath12k_base *ab,
>> +                          enum ath12k_firmware_mode mode) {
>> +     int ret;
>> +
>> +     ret =3D ath12k_wmi_attach(ab);
>> +     if (ret) {
>> +             ath12k_err(ab, "failed to attach wmi: %d\n", ret);
>> +             return ret;
>> +     }
>> +
>> +     ret =3D ath12k_htc_init(ab);
>> +     if (ret) {
>> +             ath12k_err(ab, "failed to init htc: %d\n", ret);
>> +             goto err_wmi_detach;
>> +     }
>> +
>> +     ret =3D ath12k_hif_start(ab);
>> +     if (ret) {
>> +             ath12k_err(ab, "failed to start HIF: %d\n", ret);
>> +             goto err_wmi_detach;
>> +     }
>> +
>> +     ret =3D ath12k_htc_wait_target(&ab->htc);
>> +     if (ret) {
>> +             ath12k_err(ab, "failed to connect to HTC: %d\n", ret);
>> +             goto err_hif_stop;
>> +     }
>> +
>> +     ret =3D ath12k_dp_htt_connect(&ab->dp);
>> +     if (ret) {
>> +             ath12k_err(ab, "failed to connect to HTT: %d\n", ret);
>> +             goto err_hif_stop;
>> +     }
>> +
>> +     ret =3D ath12k_wmi_connect(ab);
>> +     if (ret) {
>> +             ath12k_err(ab, "failed to connect wmi: %d\n", ret);
>> +             goto err_hif_stop;
>> +     }
>> +
>> +     ret =3D ath12k_htc_start(&ab->htc);
>> +     if (ret) {
>> +             ath12k_err(ab, "failed to start HTC: %d\n", ret);
>> +             goto err_hif_stop;
>> +     }
>> +
>> +     ret =3D ath12k_wmi_wait_for_service_ready(ab);
>> +     if (ret) {
>> +             ath12k_err(ab, "failed to receive wmi service ready event:=
 %d\n",
>> +                        ret);
>> +             goto err_hif_stop;
>> +     }
>> +
>> +     ret =3D ath12k_mac_allocate(ab);
>> +     if (ret) {
>> +             ath12k_err(ab, "failed to create new hw device with mac802=
11
>:%d\n",
>> +                        ret);
>> +             goto err_hif_stop;
>> +     }
>> +
>> +     ath12k_dp_cc_config(ab);
>> +
>> +     ath12k_dp_pdev_pre_alloc(ab);
>> +
>> +     ret =3D ath12k_dp_rx_pdev_reo_setup(ab);
>> +     if (ret) {
>> +             ath12k_err(ab, "failed to initialize reo destination rings=
: %d\n",
>ret);
>> +             goto err_mac_destroy;
>> +     }
>> +
>> +     ret =3D ath12k_wmi_cmd_init(ab);
>> +     if (ret) {
>> +             ath12k_err(ab, "failed to send wmi init cmd: %d\n", ret);
>> +             goto err_reo_cleanup;
>> +     }
>> +
>> +     ret =3D ath12k_wmi_wait_for_unified_ready(ab);
>> +     if (ret) {
>> +             ath12k_err(ab, "failed to receive wmi unified ready event:=
 %d\n",
>> +                        ret);
>> +             goto err_reo_cleanup;
>> +     }
>> +
>> +     /* put hardware to DBS mode */
>> +     if (ab->hw_params->single_pdev_only) {
>> +             ret =3D ath12k_wmi_set_hw_mode(ab,
>WMI_HOST_HW_MODE_DBS);
>> +             if (ret) {
>> +                     ath12k_err(ab, "failed to send dbs mode: %d\n", re=
t);
>> +                     goto err_hif_stop;
>
>Should it goto err_reo_cleanup?
Right. Will fix it. Thanks.

Sriram.R