Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 14 Oct 2022 12:37:56 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     haim.dreyfuss@intel.com
Cc:     linux-wireless@vger.kernel.org
Subject: [bug report] wifi: iwlwifi: mvm: trigger resume flow before wait for
 notifications
Message-ID: <Y0kt9GZ92v6Jjtsm@kili>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?F9Ot78FlbQjXReDWQ2xd6m3k0XF3hEkAXIFRg5Vx+fJldoqnhCqwc/8jmazg?=
 =?us-ascii?Q?T8vfAjRTgyxPgipeTSZMw3H6mNf0muUr/ZxGZCHlukmm/FChFLLzheyoC641?=
 =?us-ascii?Q?S0Xngjx6hyBu5JYDlvul/c8A8wQLbXkjIAI83YO0IDtstqVXN64eQswphYp0?=
 =?us-ascii?Q?vdfBJgNpR0DYnzCLJFHIvRSPzLtESfQM96OVtcoguQZyJTNSciFMVP/hjgtZ?=
 =?us-ascii?Q?YTTmG/+ypAGYmumupMkxw0QxO3rx7JpxgYn50pcdar3bTK2+/1v1GLnmtN6G?=
 =?us-ascii?Q?mYcdVMCMNXicgMGgMhg8vmcDmUZVXpn8QKkE1yiey91OtgZpYsoYGMKmjYAP?=
 =?us-ascii?Q?lRLYFKR3DWaoIq64Z2B6g5u+ifNT7bxQhzO1iq43Tz7gNpt9dyq+PXlmQ3Rq?=
 =?us-ascii?Q?XANpwUlBUIO76DFkUpmWXUFGD6gav34TyUr9JQjchveMHOdlbcviJdO5oNf7?=
 =?us-ascii?Q?B9+CZEg+zWsod9G5B8jCq/KqOtjp7DQ4ZA/HuVc4sy1oGpsdCYlB+R0Cik0I?=
 =?us-ascii?Q?Foxy0hHoLtyMfcS9wIZAxNWP/C7I00GzIqMFCNaMarr2z3EMdiavXmtpzcCt?=
 =?us-ascii?Q?lS8lSPbcs65ESOLDiiX+913euFsYsoHz5jaF+iPpTs1/skOrdhONJkWuhuPz?=
 =?us-ascii?Q?6br0VvFP6WpC8xczJjlTjOjGFUHC+AtV9O+mcHCHe5yzoQDX97FTIOhg0pFs?=
 =?us-ascii?Q?oXZQF/+XMVFh159sqgABOLBFLm4tKhGLGFRrDWCuXS3bXaG7HqxU7QM6/R8a?=
 =?us-ascii?Q?W6GvUWWKX6lD/xCQCv+ETh4bm3XQ5mLkEoNgTQXixJfohRYmWpXwii1MSxok?=
 =?us-ascii?Q?lm2HS/J0fwgGxc+kOv+WmgF2WtOz3iU9w/0C7iU1DTWHfncaDv8FQpjbFmQm?=
 =?us-ascii?Q?ZMJkmL1RD5tmkrpNoWq/WSSaozPCwdQfbl77KQ80jAqZFyRq4xR0tSBnlDVH?=
 =?us-ascii?Q?KVAd6LaE7X1h7oe6sQhLdC0hixPo5LYGTbmv5Fs3nk7E+zxntJ0HEPKqUuqP?=
 =?us-ascii?Q?rY5ZnUu5J3n/B6N6s/f7/P7g8+gviCrwH2W1ZB7EjdF8hiHryryFGEnyzH/k?=
 =?us-ascii?Q?rCMjOEFtnHKAv7FYbY4oHEn51DdKBIzexOmTfcC4ecHP0A/sGVSe/C1IuVzU?=
 =?us-ascii?Q?AX27lD4ZNbAPErdLZA5S1bkpZNd1HZ5MguZXUoJGUpQffL8BWa71NFJPCXLO?=
 =?us-ascii?Q?W4kW98dtseD4Pj3Hn2Aj9L27HmFToSPJORtlKcXy3lpQDJLDzDLpyZubVqNZ?=
 =?us-ascii?Q?NDYGvJ0JDVteJFW64rA0wonRA5XUUW+yvXq+TeOVAs2Fmi0YHwxdKZDg/8Ho?=
 =?us-ascii?Q?Z92h8lb7kVv5H91p11OS1pAl90qVl6Kn0/IrBFop1TwgDQGg+KKSMFWCy4I+?=
 =?us-ascii?Q?QP29zaOxu8FZp9qOIq/lPyueJIIUNcRLjLkLnUb0OcF4hJh5OxWKd8o4h8hB?=
 =?us-ascii?Q?VmvMNRD+S01xLYq0Q3QasxIVQ526NQzdWCxX8tak3OL1CXoRZTaQkyac7f+f?=
 =?us-ascii?Q?6kj3Wxub/sKTWA0ebogyQfMudyOoz05LZrokuZBNlWztaiZh3S5B3pMZB1PZ?=
 =?us-ascii?Q?rIggHUpUK+pYsy3TDFHwMj3Al/QrZkZKxe60/AlmRRmwJowps//Sf8c4dnVl?=
 =?us-ascii?Q?YQ=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b38487b3-56e2-4ef6-d0ad-08daadc7ca17
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2022 09:38:02.9033
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hMKelyHb9vVmkLMnBc/1LyQ/TjP87pnPuO4RlsMbBWXofgHRJ4zFJimPQB8mYRoLMxlCosfKuddZmFJTLsFo/tkmZFWYfRorw2MF1ZwFK0M=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4531
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-14_05,2022-10-13_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0
 malwarescore=0 mlxscore=0 spamscore=0 bulkscore=0 mlxlogscore=999
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2210140054
X-Proofpoint-ORIG-GUID: Jcfhcg7mn8xNVD4zKwshWQN1Fw0Z-hDn
X-Proofpoint-GUID: Jcfhcg7mn8xNVD4zKwshWQN1Fw0Z-hDn
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

Hello Haim, Dreyfuss,

The patch b75dac847c94: "wifi: iwlwifi: mvm: trigger resume flow
before wait for notifications" from Sep 6, 2022, leads to the
following Smatch static checker warning:

	drivers/net/wireless/intel/iwlwifi/mvm/d3.c:2791 iwl_mvm_resume_firmware()
	error: uninitialized symbol 'd3_status'.

drivers/net/wireless/intel/iwlwifi/mvm/d3.c
    2776 static int iwl_mvm_resume_firmware(struct iwl_mvm *mvm, bool test)
    2777 {
    2778         int ret;
    2779         enum iwl_d3_status d3_status;
    2780         struct iwl_host_cmd cmd = {
    2781                         .id = D0I3_END_CMD,
    2782                         .flags = CMD_WANT_SKB | CMD_SEND_IN_D3,
    2783                 };
    2784         bool reset = fw_has_capa(&mvm->fw->ucode_capa,
    2785                                  IWL_UCODE_TLV_CAPA_CNSLDTD_D3_D0_IMG);
    2786 
    2787         ret = iwl_trans_d3_resume(mvm->trans, &d3_status, test, !reset);

Drivers are not required to impliment a ->d3_resume op and if they don't
then d3_status is not initialized.

    2788         if (ret)
    2789                 return ret;
    2790 
--> 2791         if (d3_status != IWL_D3_STATUS_ALIVE) {
                     ^^^^^^^^^
Uninitialized

    2792                 IWL_INFO(mvm, "Device was reset during suspend\n");
    2793                 return -ENOENT;
    2794         }
    2795 
    2796         /*
    2797          * We should trigger resume flow using command only for 22000 family
    2798          * AX210 and above don't need the command since they have
    2799          * the doorbell interrupt.
    2800          */
    2801         if (mvm->trans->trans_cfg->device_family <= IWL_DEVICE_FAMILY_22000 &&
    2802             fw_has_capa(&mvm->fw->ucode_capa, IWL_UCODE_TLV_CAPA_D0I3_END_FIRST)) {
    2803                 ret = iwl_mvm_send_cmd(mvm, &cmd);
    2804                 if (ret < 0)
    2805                         IWL_ERR(mvm, "Failed to send D0I3_END_CMD first (%d)\n",
    2806                                 ret);
    2807         }
    2808 
    2809         return ret;
    2810 }

regards,
dan carpenter