Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp4054405rwi; Mon, 17 Oct 2022 00:19:31 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5NoH/NneYLrLHtxErB3yQ0tWaXKP+h2c0XObfAWtqTCUvpkTg8WdAv8lf9kFIkI/Aeeqms X-Received: by 2002:a63:6b09:0:b0:453:88a9:1d18 with SMTP id g9-20020a636b09000000b0045388a91d18mr9421334pgc.41.1665991171097; Mon, 17 Oct 2022 00:19:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665991171; cv=none; d=google.com; s=arc-20160816; b=KcmqE93bvV00lmHEMkXCOTA5EG1lJWLiwa5aOibv8zdmLLAsykprJc+JwWWqVbRki9 jvbi4gM7lkPbcrUeAwQrQwPq0DXBJotmB7U/tCwyckpGHSKIlgtsU9bci67AqGVy+NLl 6c2n93WqWHfYAcuPFT2/oTPhD6HOyhKIiztvyr+pu3whlGGqLbRZ1c62ccq+wIvoc83U Of9KXybXl8xiDFUXL3F0F6LZoVRiopP3IFhtx+wB+310KKqAbzuRT2C1NAWN/KB+dCwK /WHc6wbGzpt4U0AZP0Ph/nOPFhIhLVSC3xaiVzTr1TKtN6hyLGmZlYr5mnlVCdz381RH /Yiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:references :cc:to:from:content-language:subject:user-agent:mime-version:date :message-id:dkim-signature; bh=BhlGNW953+5Y219pY2aK+nsabIJDn+S+PDNng0R+ELE=; b=sqwvuioiKrFGPmj2dEAodPncRGt93yma+nJLVmdDeSB1Fj0+xLfTDRt4/AnTMaNnuy f5MP1TyPa6scfqmcnpaxr4IfcWoegfCezSx0LTPpI6/6l+DfnBGt+Sgk994hdh2gW++b x2X3f3LjDWH1UXxs9BTnF8f90OrAcfi4EMTXG050ccRnvfOHcrLjOTrMTKl/Jh4nnHkV tYdwYahIDxKBsOPtad2oQcNLtVNL0R+yvB1/8cF8HNeGlKU3xZjB1TjVrbgS67ENIoXM dnpa+tZ4R+urNvCqIGBg7M4xRtGBLfh6AS5oO1IvgkqJik8AKAZLGF/TDy8bO8k7YKR6 /UWQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=J1zTMi03; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 207-20020a6300d8000000b0046154b597cfsi10377769pga.565.2022.10.17.00.19.21; Mon, 17 Oct 2022 00:19:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=J1zTMi03; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229965AbiJQHKz (ORCPT + 63 others); Mon, 17 Oct 2022 03:10:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230143AbiJQHKu (ORCPT ); Mon, 17 Oct 2022 03:10:50 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D024158B76 for ; Mon, 17 Oct 2022 00:10:43 -0700 (PDT) Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29H77PxL018508; Mon, 17 Oct 2022 07:10:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : from : to : cc : references : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=BhlGNW953+5Y219pY2aK+nsabIJDn+S+PDNng0R+ELE=; b=J1zTMi03xDWuCal5YBeYRUmcn2aOqR6XE662Y+SeVOFCydXLj+m7QeScaWNO/11ZUO59 52v333rD6/8ULNtHre8UFJiC2CVgxkd+WHKveZ9VAc1OO0W5w+B32vcOMs2Pswe8nOI7 n2jLL2LJLfSbGKs4XzoOdwylNCD314AePN+mlLwc9IsKfQcan8i4VRWGbPrCO7GI4T4N OMMRXpksC9VSyBozxmu7/WRgGjU2l5uzyvx592fFZkl8Ips+McysavenERiA/L0JCZ7J okLKsA0NoiKb+5xgojD15HgXdqbfT0uJOBh23OVnmWu04yAzU0f3Q7LiIez0409tmmD1 lA== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3k7kvgbd9r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 17 Oct 2022 07:10:28 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 29H7ARGT025132 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 17 Oct 2022 07:10:27 GMT Received: from [10.231.195.37] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Mon, 17 Oct 2022 00:10:25 -0700 Message-ID: <1a440c62-ffd0-9602-9454-f08765beadf0@quicinc.com> Date: Mon, 17 Oct 2022 15:10:23 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: wifi: mac80211: mlo rx nss value 0 of wifi Content-Language: en-US From: Wen Gong To: Johannes Berg , linux-wireless CC: References: <913ee04f-a16f-f765-96c2-0586282831b4@quicinc.com> In-Reply-To: <913ee04f-a16f-f765-96c2-0586282831b4@quicinc.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: 5Yqr-mI0_OPkrZmMzcUA1RIEScPzYWJo X-Proofpoint-GUID: 5Yqr-mI0_OPkrZmMzcUA1RIEScPzYWJo X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-10-17_06,2022-10-17_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 lowpriorityscore=0 impostorscore=0 suspectscore=0 clxscore=1015 malwarescore=0 priorityscore=1501 phishscore=0 mlxlogscore=835 mlxscore=0 spamscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2210170041 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Hi Johannes, May I get your comment about this? On 9/13/2022 12:37 PM, Wen Gong wrote: > Hi Johannes, > > Currently for MLO test, the others links's rx_nss of struct > ieee80211_link_sta is still value 0 in ieee80211_set_associated(), > becaue they are not pass into ieee80211_sta_set_rx_nss() in > mac80211 except the deflink which means the primary link in > rate_control_rate_init(). This lead driver get nss = 0 for > other links. Will you fix it or is it design by default? > > Only primary link has valid rx_nss value which is not 0 by below call > stack. > ieee80211_assoc_success() >     ->rate_control_rate_init(sta); >         ->ieee80211_sta_set_rx_nss(&sta->deflink);