Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp4088406rwi; Mon, 17 Oct 2022 00:58:50 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5C/WvcWVyXhCIbZzVqdbg+G87Ke+kIWfpjhC/n9Pbj752aI2uhhwqha+85W+lahhTKPcyt X-Received: by 2002:a17:907:a43:b0:77b:ba98:d2f with SMTP id be3-20020a1709070a4300b0077bba980d2fmr7818605ejc.270.1665993530345; Mon, 17 Oct 2022 00:58:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665993530; cv=none; d=google.com; s=arc-20160816; b=HCiBj1hbZ70N/7jEitmAxZh65xvcdQjY4tEKLlrWNd34YDVNX0GkDoP5kCpazs+ogr +5PeXNffuFdMQMksfE6FHQbZowATlBl9pibxwQ5yCjsySd+IWWKuCMLveuYAHMijH34c hAzfevGxebGgwyvXBeqe0RzBBGfjyptgIc8P1TyWY1AWadFM5NzZj5WX4HrXEyYf9SUO ik2350oGgk5uy5k+SHk6Z1f8GcOH3i6A2EFPGtzFQaPkOkdnHONGE0AoZOzb/aVOPZdh t/wvq9ssCiSgpzenDJThldtE06MfAcpY6b8mU44d/kHiiOsgCbl6/Iu6xA8LWuaNWYKR WImA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent :content-transfer-encoding:references:in-reply-to:date:cc:to:from :subject:message-id:dkim-signature; bh=9a7NNq4YADpNDCpXpx4tyUPrdXcESkXViOGoN7CNADI=; b=YpyB+WoDLAByMlHhN/REDqcY/aGzWiKNldyQpqPJL6a20jzUFEKRjYCw0IaY7klrwt EwQ1kbx9p2WQRzeAo+GrtMtd3q7NeESHrfh4NS9xKPBo7DlEw4kTwybGrGxP92Z3HG8p a0qli7L6LK85nQpvqC95GcujcWrrvvk3jCbVZ74oiam5JoeuiK1F4WhjO4CC2OV9rVVF 9iOcoDtWvd+LD/YgJPrV73XrvKDppwdPCUPNZ5Uq7DGjH2Q3huc/axVihwZ3mC+Z/3k9 rmh0WZKdTweyfRNa1dRLSxF90l+7EfxZv6frxtqVnXx9kc+9sWPmQpRHJKPGg5DVggUl 4BPQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=kl36AAH3; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id oz41-20020a1709077da900b00782a33f2850si8778958ejc.736.2022.10.17.00.58.34; Mon, 17 Oct 2022 00:58:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=kl36AAH3; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229920AbiJQHsq (ORCPT + 63 others); Mon, 17 Oct 2022 03:48:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230268AbiJQHsm (ORCPT ); Mon, 17 Oct 2022 03:48:42 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9FAD35B065 for ; Mon, 17 Oct 2022 00:48:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=9a7NNq4YADpNDCpXpx4tyUPrdXcESkXViOGoN7CNADI=; t=1665992916; x=1667202516; b=kl36AAH35vFAuIaMzo5get2PH7FBKeqdyHxBsMMm7tZCwMO UQV6UM03/A+BY8OP/BF9I/tEcYGhervfn1o0OPSsEXqjL1NuDWsl3WRX0kPKz+rfmUmliy5tmkJf7 nBBcX9wPtCIC3ueiw4LfYIK0tRIJchzfSGYYTmah0wVjvmFRtzMd/7vVevrzjT1Lw3iPXwV6BpiNQ qA8FoHyxb+Cbp5jCTxestx6fuh+k0TE3+CN+m8ml1XUFqItthTzmUyFAOZynMa+dSAMe0b6wnw1iD GJHKkRXbJrvm7BiRJjRiL5jeYfFjUBfYHUcazDH0SvksprLtTnSQHOXUYOu9FnZQ==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96) (envelope-from ) id 1okKrS-009BM9-0J; Mon, 17 Oct 2022 09:48:34 +0200 Message-ID: <91b975e2116521cfa9f9371a976039a53ed9a85c.camel@sipsolutions.net> Subject: Re: wifi: mac80211: mlo rx nss value 0 of wifi From: Johannes Berg To: Wen Gong , linux-wireless Cc: ath11k@lists.infradead.org Date: Mon, 17 Oct 2022 09:48:33 +0200 In-Reply-To: <1a440c62-ffd0-9602-9454-f08765beadf0@quicinc.com> References: <913ee04f-a16f-f765-96c2-0586282831b4@quicinc.com> <1a440c62-ffd0-9602-9454-f08765beadf0@quicinc.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) MIME-Version: 1.0 X-malware-bazaar: not-scanned X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Hi, > > Currently for MLO test, the others links's rx_nss of struct > > ieee80211_link_sta is still value 0 in ieee80211_set_associated(), > > becaue they are not pass into ieee80211_sta_set_rx_nss() in > > mac80211 except the deflink which means the primary link in > > rate_control_rate_init(). This lead driver get nss =3D 0 for > > other links. Will you fix it or is it design by default? > >=20 > > Only primary link has valid rx_nss value which is not 0 by below call= =20 > > stack. > > ieee80211_assoc_success() > > =C2=A0=C2=A0=C2=A0 ->rate_control_rate_init(sta); > > =C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0 ->ieee80211_sta_set_rx_nss(&sta->= deflink); Right, none of the rate scaling related stuff was updated yet. Want to work on it? :) johannes