Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ca0f6ea2d78538ffb6640f2e56d65c89c86f5221.camel@sipsolutions.net>
Subject: Re: wifi: mac80211: mlo rx nss value 0 of wifi
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Wen Gong <quic_wgong@quicinc.com>,
        linux-wireless <linux-wireless@vger.kernel.org>
Cc:     ath11k@lists.infradead.org
Date:   Mon, 17 Oct 2022 10:02:45 +0200
In-Reply-To: <c52e6634-4a90-f165-9f41-8f23df9414a4@quicinc.com>
References: <913ee04f-a16f-f765-96c2-0586282831b4@quicinc.com>
         <1a440c62-ffd0-9602-9454-f08765beadf0@quicinc.com>
         <91b975e2116521cfa9f9371a976039a53ed9a85c.camel@sipsolutions.net>
         <2a2c466fbdcc2c3cc7af81bcd4d370d0119ea865.camel@sipsolutions.net>
         <c52e6634-4a90-f165-9f41-8f23df9414a4@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Mon, 2022-10-17 at 16:00 +0800, Wen Gong wrote:
> On 10/17/2022 3:49 PM, Johannes Berg wrote:
> > On Mon, 2022-10-17 at 09:48 +0200, Johannes Berg wrote:
> > > Hi,
> > >=20
> > > > > Currently for MLO test, the others links's rx_nss of struct
> > > > > ieee80211_link_sta is still value 0 in ieee80211_set_associated()=
,
> > > > > becaue they are not pass into ieee80211_sta_set_rx_nss() in
> > > > > mac80211 except the deflink which means the primary link in
> > > > > rate_control_rate_init(). This lead driver get nss =3D 0 for
> > > > > other links. Will you fix it or is it design by default?
> > > > >=20
> > > > > Only primary link has valid rx_nss value which is not 0 by below =
call
> > > > > stack.
> > > > > ieee80211_assoc_success()
> > > > >  =C2=A0=C2=A0=C2=A0 ->rate_control_rate_init(sta);
> > > > >  =C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0 ->ieee80211_sta_set_rx_nss=
(&sta->deflink);
> > > Right, none of the rate scaling related stuff was updated yet.
> > >=20
> > Though for this case maybe we can just move ieee80211_sta_set_rx_nss()
> > to some better place outside of rate_control_rate_init() and have it
> > done with the right link, and also on changes?
> >=20
> > johannes
>=20
> I did below change in my internal test, and not found the NSS=3D0 issue=
=20
> again for 2 link MLO.
>=20
> wifi: mac80211: update all links rx nss by ieee80211_sta_set_rx_nss() in=
=20
> ieee80211_assoc_success()
>=20

I guess valid links wasn't set at that point yet?

Anyway should also move out of rate_control_rate_init() and probably
into something like ieee80211_assoc_config_link()? That already does
some rx_nss calculations which is probably not great ...

johannes