Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp4107523rwi; Mon, 17 Oct 2022 01:17:45 -0700 (PDT) X-Google-Smtp-Source: AMsMyM64ySgA5bZQu+YB4myO0IxXzfeuUYkgt2JUkhElcZ9RgrB/7XrrVZepNL90UfX0/50W4tRT X-Received: by 2002:a17:90b:1e4b:b0:20d:8cf0:1a3c with SMTP id pi11-20020a17090b1e4b00b0020d8cf01a3cmr12654075pjb.172.1665994665141; Mon, 17 Oct 2022 01:17:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665994665; cv=none; d=google.com; s=arc-20160816; b=uuo+bHKAniOXSWsDbaX4D6Tbsfh73YoxrRdAbSdmuEQujieGNr5N9wuTfkDNNpZQja TA6Sfue3RD/3cYoxmLes72qZBipiHF6v91pjg+q8SMHEKcRpr1UCWNdbcN5io98lle5X CxlD25B7Rv5SEUEX4gcErEW54llijtACUSbSjWnEIUVgiGEfwxf88NRlSTXScFdgQqpc AWPcESvClPQrUwFPu3amWTzKd14IJ7y5eq3PX7kKYzZnoOtNwLeiDuP0PeoiXoa5h2hW 4OZTFeoxBjC0uk+ajWIFT51q+DA5fbNQJwoqaBA0I5qD6kNEXckoZwili6h8dWvPGQ8E Cqhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent :content-transfer-encoding:references:in-reply-to:date:cc:to:from :subject:message-id:dkim-signature; bh=IxT765SpRu/AccEWgVHDP2HHCCrUqfmWUft6GnhhGmk=; b=V3Eg9tskMHxlb0XtLqA0vZRFBxgrJ8UCFu1YDIAITHXiiJHZEPGyRK56dwTXPmcD33 7Kj8lIhnl+XFVZbvAIaGuM6Ylm9dNUyhvSDLRThhGva9vsEn4/ymxlnUn8RNho3mDM2K McdrDX8FzgNKZ41JvOnntJrPspGKs/hWp2JCO0SYsh81twA/d5NxV494yCThBPq9MJlG /VizzG/c1iA3uEZzrW4ojcUMxOJBg09u7NCmcv/eYUayyK3DjpMtvTrcyVoZA9yL/ONl 4LENlY1aGe8uaN76Mn1RFhDZuW1DBTaYGZbKyskoF8beEpUBVv4o5F6c19re81oenpyM +g6g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b="h/OxQXLP"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l7-20020a170903120700b001786399ba31si12547502plh.590.2022.10.17.01.17.35; Mon, 17 Oct 2022 01:17:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b="h/OxQXLP"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230060AbiJQIOy (ORCPT + 63 others); Mon, 17 Oct 2022 04:14:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51084 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230215AbiJQIOo (ORCPT ); Mon, 17 Oct 2022 04:14:44 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A09825FE for ; Mon, 17 Oct 2022 01:14:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=IxT765SpRu/AccEWgVHDP2HHCCrUqfmWUft6GnhhGmk=; t=1665994478; x=1667204078; b=h/OxQXLP1ZzZ7h2M7kyUavRqz3uBNyAbaaoP1b37AGhwRlP R2gzzwPzP4VqiWTphMtHyYqmdLrOJmF5GFKXTyAxs0ZDK/sBO8UpLds1LZs90w6YaqsfsNCUJDqaB 7icpwljv/v+utjsFh9ONHUkWEWhg0YlbH5t/jiq/hrPuBr/1Y/lbgzOgmFbYXoOEgMgFQ9PYaeFwk tdH1dS7n8krz/fCH7ZD764tbkRmcHj1AAmkFSdoAoW4BlsWuRaMues8Hrp7dzLPFQG9I8G+JqSz2c a3llbJ+45uZp3WSs6PA0UEOa903ZUmKX3xTRy1r7G0ghwxkaypVneOyqeYIOXSjw==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96) (envelope-from ) id 1okLGQ-009CHG-1a; Mon, 17 Oct 2022 10:14:22 +0200 Message-ID: Subject: Re: wifi: mac80211: mlo rx nss value 0 of wifi From: Johannes Berg To: Wen Gong , linux-wireless Cc: ath11k@lists.infradead.org Date: Mon, 17 Oct 2022 10:14:21 +0200 In-Reply-To: <191042d8-7781-808f-71aa-db76ed763bec@quicinc.com> References: <913ee04f-a16f-f765-96c2-0586282831b4@quicinc.com> <1a440c62-ffd0-9602-9454-f08765beadf0@quicinc.com> <91b975e2116521cfa9f9371a976039a53ed9a85c.camel@sipsolutions.net> <2a2c466fbdcc2c3cc7af81bcd4d370d0119ea865.camel@sipsolutions.net> <191042d8-7781-808f-71aa-db76ed763bec@quicinc.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) MIME-Version: 1.0 X-malware-bazaar: not-scanned X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Mon, 2022-10-17 at 16:12 +0800, Wen Gong wrote: > > >=20 > > I guess valid links wasn't set at that point yet? > >=20 > > Anyway should also move out of rate_control_rate_init() and probably > > into something like ieee80211_assoc_config_link()? That already does > > some rx_nss calculations which is probably not great ... >=20 > OK. I will test with my change internal now. And replace to use upstream= =20 > change >=20 > after someone fix it. >=20 Well, I think you should try to fix it and submit the patch, I'm not going to do it in the short term ... :) johannes