Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3483d05c1d5a39b9243b54d9f28450344a897655.camel@sipsolutions.net>
Subject: Re: [PATCH 01/15] mac80211: split bss_info_changed method
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Wen Gong <quic_wgong@quicinc.com>, linux-wireless@vger.kernel.org
Cc:     ath11k@lists.infradead.org, ath12k@lists.infradead.org
Date:   Tue, 18 Oct 2022 10:50:11 +0200
In-Reply-To: <c38b4da8-488b-2d09-631a-1bb6c07440a6@quicinc.com>
References: <20220601073958.8345-1-johannes@sipsolutions.net>
         <20220601093922.347d47c279fe.I15937cfe8405999084f164ddf57390f8b8d2bc61@changeid>
         <c38b4da8-488b-2d09-631a-1bb6c07440a6@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Tue, 2022-10-18 at 16:47 +0800, Wen Gong wrote:
>=20
> > +	if (changed & ~BSS_CHANGED_VIF_CFG_FLAGS) {
> > +		/* FIXME: should be for each link */
> > +		trace_drv_link_info_changed(local, sdata, 0, changed);
> > +		if (local->ops->link_info_changed)
> > +			local->ops->link_info_changed(&local->hw, &sdata->vif,
> > +						      0, changed);
>=20
> I think you/someone will change here later for the "/* FIXME: should be=
=20
> for each link */", right?

Maybe. I'm not actually sure it's really needed, it depends how we use
this in the future.

> It lead error/kernel crash as below while reconfig single MLO link which=
=20
> link id is 2.
> When test with single MLO link which link id is 0, not found=20
> error/kernel crash.

I'm not surprised, I just worked on fixing reconfig in the last few
days, will post it after some more review/testing.

So I think that might not need changes *here*, but rather a proper FW
restart. Which I haven't tested in AP mode though -- was the crash in AP
mode?

johannes