Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <52d15e34cf20ddb372b2791c18776405f57d2516.camel@gmail.com>
Subject: Reassociation is broken via CMD_CONNECT
From:   James Prestwood <prestwoj@gmail.com>
To:     linux-wireless@vger.kernel.org
Date:   Tue, 18 Oct 2022 10:13:43 -0700
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.40.4 (3.40.4-5.fc34) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

Based on the documentation for PREV_BSSID:

"previous BSSID, to be used in ASSOCIATE and CONNECT commands to
specify a request to reassociate within an ESS, i.e., to use
Reassociate Request frame"

But this actually isn't true when using CMD_CONNECT. The kernel does a
full re-connect if PREV_BSSID is provided (easily verified by kernel
logs which show an Authenticate frame being sent).

This is due to, in part, cfg80211_sme_connect() calling
cfg80211_get_conn_bss() which sets the connection state to
CFG80211_CONN_AUTHENTICATE_NEXT.

I tried hacking this to set it to CFG80211_CONN_ASSOCIATE_NEXT if
prev_bssid was set, but was unable to reassociate. I think the
CMD_CONNECT path just needs to call rdev_assoc directly if PREV_BSSID
is included? or some other modifications to cfg80211_sme_connect()?

Thanks,
James