Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1258a2cf-af82-3a58-a4b5-e0fcd961bf4b@quicinc.com>
Date:   Wed, 19 Oct 2022 17:40:25 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: wifi: mac80211: Re: unicast probe response bssid changed by
 "wifi: mac80211: do link->MLD address translation on RX"
Content-Language: en-US
To:     Johannes Berg <johannes@sipsolutions.net>,
        linux-wireless <linux-wireless@vger.kernel.org>
CC:     <ath11k@lists.infradead.org>, <ath12k@lists.infradead.org>
References: <e1c5fbac-7e6e-c643-f24d-32cec779f2d3@quicinc.com>
 <9fe7c0f2-e02f-e87f-dced-90e973c8992f@quicinc.com>
 <5f652efb43226f67e932f5aaf97cd717992bfd81.camel@sipsolutions.net>
From:   Wen Gong <quic_wgong@quicinc.com>
In-Reply-To: <5f652efb43226f67e932f5aaf97cd717992bfd81.camel@sipsolutions.net>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 10/19/2022 5:38 PM, Johannes Berg wrote:
> On Wed, 2022-10-19 at 17:35 +0800, Wen Gong wrote:
>> On 9/14/2022 11:13 AM, Wen Gong wrote:
>>> Hi Johannes,
>>>
>>> The mac addr of unicast rx packet all changed to the MLD address by
>>> below patch.
>>> Now the probe presponse which is unicast packet is also changed mac
>>> address here.
>>> I found bssid which is the MLD address of my test AP in
>>> cfg80211_get_bss().
>>> For example, if the AP has 2 mlo links, link 1 is 5 GHz band, link 2
>>> is 2.4 GHz band,
>>> then the 2 probe reponse will be changed to a same one.
>>> seems we should skip probe presponse for the mac address change here,
>>> right?
>>>
>>> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?id=42fb9148c078004d07b4c39bd7b1086b6165780c
>>>
>>> wifi: mac80211: do link->MLD address translation on RX
>>>
>> Hi Johannes,
>>
>> May I get your comment about this?
> Yes I've actually seen this issue as well.
>
>> I did below change in my local test to workaround the issue.
>>
>> diff --git a/net/mac80211/rx.c b/net/mac80211/rx.c
>> index a57811372027..eaff5353520a 100644
>> --- a/net/mac80211/rx.c
>> +++ b/net/mac80211/rx.c
>> @@ -4858,7 +4858,8 @@ static bool ieee80211_prepare_and_rx_handle(struct
>> ieee80211_rx_data *rx,
>>            shwt->hwtstamp = skb_hwtstamps(skb)->hwtstamp;
>>        }
>>
>> -    if (unlikely(link_sta)) {
>> +    if (unlikely(link_sta) &&
>> +        !(ieee80211_is_probe_resp(hdr->frame_control))) {
>>            /* translate to MLD addresses */
>>
> Maybe it should also be for beacons or so?
>
> johannes
Yes, it should also for beacons.