Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5f652efb43226f67e932f5aaf97cd717992bfd81.camel@sipsolutions.net>
Subject: Re: wifi: mac80211: Re: unicast probe response bssid changed by
 "wifi: mac80211: do link->MLD address translation on RX"
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Wen Gong <quic_wgong@quicinc.com>,
        linux-wireless <linux-wireless@vger.kernel.org>
Cc:     ath11k@lists.infradead.org, ath12k@lists.infradead.org
Date:   Wed, 19 Oct 2022 11:38:32 +0200
In-Reply-To: <9fe7c0f2-e02f-e87f-dced-90e973c8992f@quicinc.com>
References: <e1c5fbac-7e6e-c643-f24d-32cec779f2d3@quicinc.com>
         <9fe7c0f2-e02f-e87f-dced-90e973c8992f@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Wed, 2022-10-19 at 17:35 +0800, Wen Gong wrote:
> On 9/14/2022 11:13 AM, Wen Gong wrote:
> > Hi Johannes,
> >=20
> > The mac addr of unicast rx packet all changed to the MLD address by=20
> > below patch.
> > Now the probe presponse which is unicast packet is also changed mac=20
> > address here.
> > I found bssid which is the MLD address of my test AP in=20
> > cfg80211_get_bss().
> > For example, if the AP has 2 mlo links, link 1 is 5 GHz band, link 2=
=20
> > is 2.4 GHz band,
> > then the 2 probe reponse will be changed to a same one.
> > seems we should skip probe presponse for the mac address change here,=
=20
> > right?
> >=20
> > https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?i=
d=3D42fb9148c078004d07b4c39bd7b1086b6165780c=20
> >=20
> > wifi: mac80211: do link->MLD address translation on RX
> >=20
> Hi Johannes,
>=20
> May I get your comment about this?

Yes I've actually seen this issue as well.

> I did below change in my local test to workaround the issue.
>=20
> diff --git a/net/mac80211/rx.c b/net/mac80211/rx.c
> index a57811372027..eaff5353520a 100644
> --- a/net/mac80211/rx.c
> +++ b/net/mac80211/rx.c
> @@ -4858,7 +4858,8 @@ static bool ieee80211_prepare_and_rx_handle(struct=
=20
> ieee80211_rx_data *rx,
>  =C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 shwt->hwtstamp =3D skb_hwtst=
amps(skb)->hwtstamp;
>  =C2=A0=C2=A0=C2=A0=C2=A0 }
>=20
> -=C2=A0=C2=A0=C2=A0 if (unlikely(link_sta)) {
> +=C2=A0=C2=A0=C2=A0 if (unlikely(link_sta) &&
> +=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 !(ieee80211_is_probe_resp(hdr->fra=
me_control))) {
>  =C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 /* translate to MLD addresse=
s */
>=20

Maybe it should also be for beacons or so?

johannes