Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1cbd1d8e-8dc5-052b-118a-0c546d5edad6@gmail.com>
Date:   Thu, 20 Oct 2022 13:29:06 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.1
Subject: Re: [PATCH v2] brcmfmac: Fixes potential buffer overflow in
 'brcmf_fweh_event_worker'
Content-Language: en-US
To:     Dokyung Song <dokyung.song@gmail.com>,
        linux-wireless@vger.kernel.org, Kalle Valo <kvalo@codeaurora.org>
Cc:     Jisoo Jang <jisoo.jang@yonsei.ac.kr>,
        Minsuk Kang <linuxlovemin@yonsei.ac.kr>
References: <20221020104954.GA461052@laguna>
From:   Arend Van Spriel <aspriel@gmail.com>
In-Reply-To: <20221020104954.GA461052@laguna>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

+ Kalle

On 10/20/2022 12:49 PM, Dokyung Song wrote:
> This patch fixes an intra-object buffer overflow in brcmfmac that occurs
> when the device provides a 'bsscfgidx' equal to or greater than the
> buffer size. The patch adds a check that leads to a safe failure if that
> is the case.

Thanks for the updated patch. The subject for all linux-wireless patches 
should begin with 'wifi:'. Sorry for noticing it not earlier. Maybe 
Kalle can correct it when applying the patch.

Regards,
Arend