Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp2156291rwi; Thu, 20 Oct 2022 23:54:13 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4HDeo36zMc/u+cXHTTbQQGuf3kpmkvhqDND0BXwAEFtbHCv9kNtHmv5RlPy4lMYqE8UGdz X-Received: by 2002:a63:2a08:0:b0:46a:e2a8:4ead with SMTP id q8-20020a632a08000000b0046ae2a84eadmr15376322pgq.132.1666335253654; Thu, 20 Oct 2022 23:54:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666335253; cv=none; d=google.com; s=arc-20160816; b=hiW047HKscbh7eGNBwXirl0CBAiTnzoklzE7nLRXaIU9F8jNIAj9/+Lxx6yz4N8Uhm DyqZyXSR/LC1xnXvOktIGHpID9mGTWTKFDK9UkCZxNzPaWdCQpqZJzQ8BbhTzqsYNwVM qaksqNjUn0F+F7r7uiyc91SiE/eR7Zl852o4HZMTnQJdy7sFKcKryPhal+60Nb9j7Miw 98e9XjXlY386JBAEK4/IDlRfGaMC93eV2KG8TPKieeOPjVj9kzCp6vAfAAuQGO8I8ky3 lqq2oBiGiERN9uMQJBCC2I4z/WWDJ22KyOjuuENe/FBvAXA2EV3W7+IhbAnfBpiGfHDt 94Ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=JZYPzMAAk04GiZewA7wlYzNDdEwr9hevG+2YIH3G6I8=; b=EVwLdQFGAUHOe87AB3xa63X4F63tYN3/4m9d6c8fVJpOmrhx1JYgDNnLQyJh3y9FX8 X+rGamJKs95RJOkV2yXt7dCE5DQy8QilMLPSEF51tfUbhMhzJ4f1wdARNrQhcolaEtR8 P52m8mPq4FJtkiaYT/u5twTunCXDV/ivL940dO8C0KgP/ljGE55yzlDozQhMVLFJ8ca2 Awibr+R8n7WJEopszkHgMdH+GzDaS/ry0J668se5ObGFr5bKtQ+IHB1sT6PMPnJENoWQ S6REftD5YelY/0IEfBNoXb7xUxZMlVp5kto362GxRz1dy6N2cdf3qTPJYL2JNLje9iMZ WEyw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=j+SseHhP; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j16-20020a62b610000000b005572895941asi21943956pff.139.2022.10.20.23.54.02; Thu, 20 Oct 2022 23:54:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=j+SseHhP; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230016AbiJUGu5 (ORCPT + 65 others); Fri, 21 Oct 2022 02:50:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33294 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230261AbiJUGtA (ORCPT ); Fri, 21 Oct 2022 02:49:00 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2F2A244C5A; Thu, 20 Oct 2022 23:48:39 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9096861D9B; Fri, 21 Oct 2022 06:48:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 207A8C433B5; Fri, 21 Oct 2022 06:48:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666334914; bh=Pa59gRcCjIAYrcKVcjxJd3h3lUsuJ0LhHiTmoynHNI0=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=j+SseHhPdz/f7nueNs3h2lsKj7fwHLqasZ4oQ50lJ6EK9RRVu38ve1M/yk4Tx6uOI EPPu8GLSibvwFgSqLwzum3D+1zNsSnGAmaGmDmzWS+1hDY3GEQ9wlG7xaI9qR4V5oy xCvup6vfI86MnAFqL76R9oTsdMKb3eIC/0zjKb65nXWn2Go73+BrN7huaptLl5fknS LfrNBaRHvaqxA8soiJ4nGkAHHanbPvXQeks6BRKEr3y54F0ctm7lu9wP6cYaxZVRSw ciE020/aAuZ5iqhyPEftpdX/Pq6/XvgC76657+eT9o2ctKIdrTzefA8LJpLMpI/t1t pscraL57di5zw== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v3] wifi: rt2x00: use explicitly signed or unsigned types From: Kalle Valo In-Reply-To: <20221019155541.3410813-1-Jason@zx2c4.com> References: <20221019155541.3410813-1-Jason@zx2c4.com> To: "Jason A. Donenfeld" Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Jason A. Donenfeld" , Andrew Morton , Andy Shevchenko , Stanislaw Gruszka , Helmut Schaa User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <166633490836.19505.7036640684401652888.kvalo@kernel.org> Date: Fri, 21 Oct 2022 06:48:31 +0000 (UTC) X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org "Jason A. Donenfeld" wrote: > On some platforms, `char` is unsigned, but this driver, for the most > part, assumed it was signed. In other places, it uses `char` to mean an > unsigned number, but only in cases when the values are small. And in > still other places, `char` is used as a boolean. Put an end to this > confusion by declaring explicit types, depending on the context. > > Cc: Andrew Morton > Cc: Andy Shevchenko > Cc: Stanislaw Gruszka > Cc: Helmut Schaa > Cc: Kalle Valo > Signed-off-by: Jason A. Donenfeld > Acked-by: Stanislaw Gruszka Patch applied to wireless.git, thanks. 3347d22eb90b wifi: rt2x00: use explicitly signed or unsigned types -- https://patchwork.kernel.org/project/linux-wireless/patch/20221019155541.3410813-1-Jason@zx2c4.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches